From owner-freebsd-bugs@FreeBSD.ORG  Tue Sep 30 20:44:40 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E1E2CF3C
 for <freebsd-bugs@FreeBSD.org>; Tue, 30 Sep 2014 20:44:40 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CA1BEB50
 for <freebsd-bugs@FreeBSD.org>; Tue, 30 Sep 2014 20:44:40 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8UKieOt066500
 for <freebsd-bugs@FreeBSD.org>; Tue, 30 Sep 2014 20:44:40 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 193873] [PATCH] Unify dumpsys() under generic kern_dump.c.
Date: Tue, 30 Sep 2014 20:44:41 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jhibbits@FreeBSD.org
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-193873-8-z6KdqqdS2V@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193873-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-193873-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Sep 2014 20:44:41 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193873

--- Comment #4 from Justin Hibbits <jhibbits@FreeBSD.org> ---
(In reply to Conrad Meyer from comment #3)
> (In reply to Justin Hibbits from comment #1)
> > Instead of wrapping with DUMPSYS_HAS_*, why not add wrapper functions in the
> > md headers, most of which simply call a common routine, with the oddballs
> > doing their own thing?
> 
> Is this something like what you had in mind? http://dpaste.com/0QRFFAS
> 
> It's a rough sketch and I haven't tried to compile it. Just want to make
> sure it seems reasonable to you before going down that path. Thanks!

Looks reasonable to me.  Thanks for doing this work!

-- 
You are receiving this mail because:
You are the assignee for the bug.