From owner-svn-src-all@freebsd.org  Thu Jan 18 23:35:31 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FB53EB3651
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Thu, 18 Jan 2018 23:35:31 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EFB71637D0
 for <svn-src-all@freebsd.org>; Thu, 18 Jan 2018 23:35:30 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 3deed409-fca8-11e7-8dac-d32f5c2d02ef
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id 3deed409-fca8-11e7-8dac-d32f5c2d02ef;
 Thu, 18 Jan 2018 23:35:19 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w0INZEmc009889;
 Thu, 18 Jan 2018 16:35:14 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1516318514.42536.30.camel@freebsd.org>
Subject: Re: svn commit: r327354 - head/sys/vm
From: Ian Lepore <ian@freebsd.org>
To: Andriy Gapon <avg@FreeBSD.org>, Matt Joras <mjoras@freebsd.org>, Warner
 Losh <imp@bsdimp.com>
Cc: "Conrad E. Meyer" <cem@freebsd.org>, Eric van Gyzen <eric@vangyzen.net>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Thu, 18 Jan 2018 16:35:14 -0700
In-Reply-To: <517c7c8c-a9a3-b8d4-10c7-81552c61784d@FreeBSD.org>
References: <201712291905.vBTJ57gI072871@repo.freebsd.org>
 <20180117224054.GO8113@FreeBSD.org>
 <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net>
 <CAG6CVpVuXUcPCX81Nv9XujRVw8psxpLSLRfG9T20w6sr4j6=PA@mail.gmail.com>
 <CANCZdfosA5+U=7vsULp2fQy_=e7TTZ5Qs2BNtHuONONg_Qdegw@mail.gmail.com>
 <CADdTf+gr7mn-8snR1gvV1weDMhnhuKs85_DbMTe+-RVOkO1nQw@mail.gmail.com>
 <517c7c8c-a9a3-b8d4-10c7-81552c61784d@FreeBSD.org>
Content-Type: text/plain; charset="ASCII"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 23:35:31 -0000

On Fri, 2018-01-19 at 00:21 +0200, Andriy Gapon wrote:
> On 18/01/2018 23:10, Matt Joras wrote:
> > 
> > "/* Insert an empty line if the function has no local variables.
> > */"
> And if there is a single silly rule in style(9) then it is this.
> Waste a line for no possible benefit at all.
> 

Especially when you consider how people bitch about empty lines
elsewhere in functions.

-- Ian