From nobody Fri Apr 24 15:28:59 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2H1R5f5bz6bSD3 for ; Fri, 24 Apr 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2H1R2VcQz3CmW for ; Fri, 24 Apr 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777044539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=01wohteJ1wOc1XajRhFeHDrjxhR47pjsW0sNbwAf40w=; b=HxVsoEtyTQ2HP9WoT1KKihdZu1WE3dgiOO6SznQhxNPCvvcVG0426bdY5So7IzFeM94kae GbtKVzeSNsy+see+DjTRf/pfi5+SbpOd6LqDpOwTeLwYs1kQkJGQxjuqrrYmIaXGuCzO0b OPmYcMs4Cw/tQ7myRPesmGJGMiWQQmpWfzDDdl0CO/t8baq3gUw8bIlq4o5xqRXvk7vBDZ Euthw3IDkYdJfHS7y/SsIufgDRcNd9cDQWxFA2CrNAM9SEBc2q+YHxMHjhJcD6KpshQ0cN +kqUQmgj2YAXWIOqdXEuUc/v5u/5IUIvJTjeBmAPE/Yqf4dgdbzqqsA/dGPqdg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777044539; a=rsa-sha256; cv=none; b=sQxuHORXOakDGJpAAbG8J1FsmDQMKZxj1WHG1+K2Orv1XNIM5cMMh2CLHjxO2yMKcMSing 6CZf6ULxN7yU3baYDf+zLzh4CAOVKeyCAi3weydpQczWHZlZt0KbOOory1j5DnCckZotn4 r44v9OwN9C8Pmofwkk6V10/vrYPQLlAB36i2gRjP0GTXUXZk5IsgiKDuDUP7PjNLKYVODN ryCq9Z95AGDGQtDEb7NvrrzqYdjT5W6nyeqXfiSpgiL/KorsUrhRWu8qwlFhEFczNb9c4m VIwS2ecEVi3UkPOZPVtU0aWZplue1V68+WnJLLqKrbPMp5Fxv10w2FFrmwQz+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777044539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=01wohteJ1wOc1XajRhFeHDrjxhR47pjsW0sNbwAf40w=; b=G5/i6IjCaUVFxZyfZht9JmhPVFGvIlgvSDMqYUGHnR7Pw/wAhWV3LFIMydJhVJ1cW71SMZ sPcjpjjpBae8SAtGzMRZ+1CBWN6ceInhst3wVylya5m9pK6eev1t35kMF9GwjLGyh0Y/cA k/XtlRlRm/r7+NvFj6aW0/tqcFaEdAkuwN+yFMFtpTzRjD1dqAxzAWQCdvOY/vM7muWuxK TROk5/bG4dfnEj/XA5vtrSqdKYBEdGKxmHvSVH+Hx6jrFW+LhBFAK463LUCQ2Kj09kd54e rvPsSaembaeAql5x8n1DAZh+Rzrwt4ZkbsiMtQsb8z+HUM3TZTZgn5792LNpkA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g2H1R1fr5z178Q for ; Fri, 24 Apr 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33dbd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 15:28:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: f6add67808f3 - stable/15 - acpi_apei: Remove the hest member from the softc List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f6add67808f332719787c4260dbb0fcf7525fb3e Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 15:28:59 +0000 Message-Id: <69eb8c3b.33dbd.6774e032@gitrepo.freebsd.org> The branch stable/15 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=f6add67808f332719787c4260dbb0fcf7525fb3e commit f6add67808f332719787c4260dbb0fcf7525fb3e Author: John Baldwin AuthorDate: 2025-12-26 15:36:24 +0000 Commit: John Baldwin CommitDate: 2026-04-24 15:26:38 +0000 acpi_apei: Remove the hest member from the softc This is only used during attach and freed after use, so just use a local variable in the attach routine instead to avoid leaving a dangling pointer around in the softc. Reviewed by: imp Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D54310 (cherry picked from commit 88f8e3c5ab97025587d7df761c8ae72e2db6c1d3) --- sys/dev/acpica/acpi_apei.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sys/dev/acpica/acpi_apei.c b/sys/dev/acpica/acpi_apei.c index 9cfd46c97430..8b79be5d97c4 100644 --- a/sys/dev/acpica/acpi_apei.c +++ b/sys/dev/acpica/acpi_apei.c @@ -86,7 +86,6 @@ struct apei_pges { }; struct apei_softc { - ACPI_TABLE_HEST *hest; TAILQ_HEAD(, apei_ge) ges; struct apei_nges nges; struct apei_iges iges; @@ -562,9 +561,8 @@ hest_parse_structure(struct apei_softc *sc, void *addr, int remaining) } static void -hest_parse_table(struct apei_softc *sc) +hest_parse_table(ACPI_TABLE_HEST *hest, struct apei_softc *sc) { - ACPI_TABLE_HEST *hest = sc->hest; char *cp; int remaining, consumed; @@ -662,6 +660,7 @@ static int apei_attach(device_t dev) { struct apei_softc *sc = device_get_softc(dev); + ACPI_TABLE_HEADER *hest; struct acpi_softc *acpi_sc; struct apei_pges *pges; struct apei_ge *ge; @@ -691,11 +690,11 @@ apei_attach(device_t dev) } /* Search and parse HEST table. */ - status = AcpiGetTable(ACPI_SIG_HEST, 0, (ACPI_TABLE_HEADER **)&sc->hest); + status = AcpiGetTable(ACPI_SIG_HEST, 0, &hest); if (ACPI_FAILURE(status)) return (ENXIO); - hest_parse_table(sc); - AcpiPutTable((ACPI_TABLE_HEADER *)sc->hest); + hest_parse_table((ACPI_TABLE_HEST *)hest, sc); + AcpiPutTable(hest); rid = 0; TAILQ_FOREACH(ge, &sc->ges, link) {