From owner-svn-ports-all@FreeBSD.ORG  Tue Feb  4 16:31:43 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F2CCCDFC;
 Tue,  4 Feb 2014 16:31:42 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id AC0171FCA;
 Tue,  4 Feb 2014 16:31:42 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id 560CABDC56;
 Tue,  4 Feb 2014 17:31:41 +0100 (CET)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "gw.in.absolight.net",
 Issuer "CA Cert Signing Authority" (not verified))
 by prod2.absolight.net (Postfix) with ESMTPSA id 3AFE2BDC2E;
 Tue,  4 Feb 2014 17:31:41 +0100 (CET)
Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239])
 by gw.in.absolight.net (Postfix) with ESMTP id 030B46119;
 Tue,  4 Feb 2014 17:31:39 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by ogg.in.absolight.net (Postfix) with ESMTP id 94FF668D3BC6;
 Tue,  4 Feb 2014 17:31:39 +0100 (CET)
Date: Tue, 04 Feb 2014 17:31:39 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Max Brazhnikov <makc@freebsd.org>
Subject: Re: svn commit: r342510 - head/games/cutemaze
Message-ID: <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>
In-Reply-To: <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk>
References: <201402041149.s14BnPX0031911@svn.freebsd.org>
 <7999310.FuPfOJuxd6@mercury.ph.man.ac.uk>
 <0490893710F9E2B81364BC6A@ogg.in.absolight.net>
 <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 16:31:43 -0000

+--On 4 f=C3=A9vrier 2014 14:36:38 +0000 Max Brazhnikov <makc@freebsd.org>
wrote:
| On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote:
|> +--On 4 f=C3=A9vrier 2014 13:05:39 +0000 Max Brazhnikov =
<makc@freebsd.org>
|> wrote:
|> |=20
|> | This part should be reverted.
|> | Folks, please *review* what makeplist generates and don't commit it
|> | blindly.
|>=20
|> I for one would love to have feedback on what the evolved makeplist
|> should do better :-)
|=20
| It's way too aggressive for PLIST_SUB and this leads to false
| substitutions  sometimes. bsd.qt.mk defines a number of QT_*DIR, but not
| all of them should  be used (actually it depends on particular port).
| We could help makeplist by telling explicitly which substitutions are
| right, e.g. by specifying OPTIONS_SUB.

Most substitutions are right, I mean, in a perl port, I want PERL_VER, and
SITE_PERL, and PERL5_MAN3, and... there are a few like QT_BINDIR which
shouldn't go in it, but it feels more like having a blacklist than a
whitelist.

Patch welcomes.

--=20
Mathieu Arnold