From owner-svn-src-head@freebsd.org Sat Aug 4 22:54:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85442105698F; Sat, 4 Aug 2018 22:54:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com [209.85.214.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 23ABC8D0D9; Sat, 4 Aug 2018 22:54:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f42.google.com with SMTP id v71-v6so13395945itb.3; Sat, 04 Aug 2018 15:54:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=rEV+DNzPux6EREf66aQOluLH9UnAgmIeMRKAgM5JXOc=; b=ZfEYDnmUQRFO7VuB/5MrpSYnwUges0HgktL2FG8hMaQZ3FNdBbicyfb4AnZJOLx4P3 UijOuSof01JA0GmqeJpWPTiuh8Hz60CbW93vOLbEmLu8gxUU2Bq4tgxKH8JbsQsFF53r Zlz92du3jnBXqfQJmlRXKGZTOi+Td84etowEMTOEXyWhVMRrFyySsoHmMINBe8V4IE/W /XROg3Diezw5USBHqx9Ooh4LSJMloukDO/1ZSs1p3Lggh/hCtvmExBUn8P/M9I9nWDwR iul8kva2mlyHKqTBiPytE1d7iywG9PnK5+N8+4VZIB2qi4+PRoKhfPzSlWxucR1TCdEO m41g== X-Gm-Message-State: AOUpUlEmZXpEyfv5HxkcvNUIMsFgMdI5oYQ8RLSK3DpueQP+5OMiSoQT Kknd/NvJJOu5vChBM3yZZJ5w7Mm9 X-Google-Smtp-Source: AAOMgpcmantsrvoObeFU5b2cKxeoYIkKiUAC0gN0oLkaZSj9OPR5/YD8VXHUa8J5J2JTgWbNPjc2Ug== X-Received: by 2002:a24:dd88:: with SMTP id t130-v6mr4023490itf.129.1533423271056; Sat, 04 Aug 2018 15:54:31 -0700 (PDT) Received: from mail-it0-f54.google.com (mail-it0-f54.google.com. [209.85.214.54]) by smtp.gmail.com with ESMTPSA id j17-v6sm1553883ita.41.2018.08.04.15.54.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Aug 2018 15:54:30 -0700 (PDT) Received: by mail-it0-f54.google.com with SMTP id e14-v6so12959421itf.1; Sat, 04 Aug 2018 15:54:30 -0700 (PDT) X-Received: by 2002:a24:a308:: with SMTP id p8-v6mr10893249ite.53.1533423270630; Sat, 04 Aug 2018 15:54:30 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:7e0a:0:0:0:0:0 with HTTP; Sat, 4 Aug 2018 15:54:30 -0700 (PDT) In-Reply-To: References: <201808021925.w72JPhIu086582@repo.freebsd.org> From: Conrad Meyer Date: Sat, 4 Aug 2018 15:54:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337165 - head/sys/fs/fuse To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 22:54:38 -0000 On Sat, Aug 4, 2018 at 3:46 PM, Warner Losh wrote: > On Thu, Aug 2, 2018 at 1:25 PM, Conrad Meyer wrote: >> >> Author: cem >> Date: Thu Aug 2 19:25:43 2018 >> New Revision: 337165 >> URL: https://svnweb.freebsd.org/changeset/base/337165 >> >> Log: >> FUSE: Bump maximum IO size to enable more performant operation >>... >> - mp->mnt_stat.f_iosize = PAGE_SIZE; >> + mp->mnt_stat.f_iosize = DFLTPHYS; > > Why DFLTPHYS instead of MAXPHYS? > > DFLTPHYS defaults to 64k, while MAXPHYS is 128k. It was chosen arbitrarily. Either is a big improvement over 4k. According to the bug reporter, 64k is a common choice in other implementations. But I have no objection to MAXPHYS. Best, Conrad