From owner-svn-src-all@FreeBSD.ORG Thu Feb 16 09:18:14 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 983FF1065670; Thu, 16 Feb 2012 09:18:14 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail15.syd.optusnet.com.au (mail15.syd.optusnet.com.au [211.29.132.196]) by mx1.freebsd.org (Postfix) with ESMTP id 129258FC0C; Thu, 16 Feb 2012 09:18:12 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail15.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q1G9I9if026882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 16 Feb 2012 20:18:10 +1100 Date: Thu, 16 Feb 2012 20:18:09 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Julian Elischer In-Reply-To: <4F3CC40D.4000307@freebsd.org> Message-ID: <20120216195726.V1707@besplex.bde.org> References: <201202160511.q1G5BZNk099785@svn.freebsd.org> <20120216181210.K1423@besplex.bde.org> <4F3CC40D.4000307@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler , Bruce Evans Subject: Re: svn commit: r231814 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2012 09:18:14 -0000 On Thu, 16 Feb 2012, Julian Elischer wrote: > On 2/16/12 12:39 AM, Bruce Evans wrote: >> On Thu, 16 Feb 2012, Eitan Adler wrote: >> >>> Log: >>> Add a timestamp to the msgbuf output in order to determine when when >>> messages were printed. >>> >>> This can be enabled with the kern.msgbuf_show_timestamp sysctl >> >> Apart from being fundamentally broken, this adds lots of bloat and >> style bugs. The msgbuf is a very low-level interface, and was >> careful not to do stuff like this. I'm still waiting for the previous >> round of breakage of it, that replaces careful atomic ops by spinlocks, >> to be backed out. Code at this level cannot use any normal locking, >> > Bruce, this is a good example of a legitimate gripe going un-noticed because > you didn't shout loud enough at the right time, at the right people. But I did, in 2 replies to a reply to its commit message in June 2011. > It's been about 20 years since we started working on this but I've finally > come to the point of saying that we need you to do more when you see > problems. > object officially if you think things should be backed out! > > your reasons here seem sound, so it's hard to see why you haven't been more > public about it. I don't use -current often enough to insist on things being backed out. The technical argument will have to suffice. Bruce