From owner-p4-projects@FreeBSD.ORG  Sat Oct  7 17:14:55 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BCA6516A47C; Sat,  7 Oct 2006 17:14:55 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9741616A415
	for <perforce@FreeBSD.org>; Sat,  7 Oct 2006 17:14:55 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 63D2143D45
	for <perforce@FreeBSD.org>; Sat,  7 Oct 2006 17:14:55 +0000 (GMT)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k97HEtg7040757
	for <perforce@FreeBSD.org>; Sat, 7 Oct 2006 17:14:55 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k97HEtKK040751
	for perforce@freebsd.org; Sat, 7 Oct 2006 17:14:55 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Sat, 7 Oct 2006 17:14:55 GMT
Message-Id: <200610071714.k97HEtKK040751@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 107430 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Oct 2006 17:14:56 -0000

http://perforce.freebsd.org/chv.cgi?CH=107430

Change 107430 by rdivacky@rdivacky_witten on 2006/10/07 17:14:07

	Fix use-after-free. I want to refcount the new undo struct.
	
	Noticed by: netchild

Affected files ...

.. //depot/projects/linuxolator/src/sys/kern/sysv_sem.c#5 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/kern/sysv_sem.c#5 (text+ko) ====

@@ -1272,10 +1272,10 @@
 	refcount_release(&p->p_semundo->refcount);
 	if (p->p_semundo->refcount == 0)
    	   	free(p->p_semundo, M_SEM);
-	refcount_acquire(&p->p_semundo->refcount);
 	PROC_LOCK(p);
 	p->p_semundo = SLIST_NEXT(suptr, un_next);
 	PROC_UNLOCK(p);
+	refcount_acquire(&p->p_semundo->refcount);
 }
 
 static int