From owner-freebsd-current  Wed Jan  8 02:51:14 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id CAA26582
          for current-outgoing; Wed, 8 Jan 1997 02:51:14 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id CAA26576
          for <current@freebsd.org>; Wed, 8 Jan 1997 02:51:06 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id VAA31604; Wed, 8 Jan 1997 21:45:20 +1100
Date: Wed, 8 Jan 1997 21:45:20 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199701081045.VAA31604@godzilla.zeta.org.au>
To: current@freebsd.org, nate@mt.sri.com
Subject: Re: Interrupt masks???
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

[>Questions for others to answer.]

>ps. Does someone want to review this patch for me?  The code uses
>INTRMASK above, so why not INTRUNMASK below?
>
>Index: pcibus.c
>===================================================================
>RCS file: /home/CVS/src/sys/i386/isa/pcibus.c,v
>retrieving revision 1.27
>diff -u -r1.27 pcibus.c
>--- pcibus.c    1996/10/30 22:38:55     1.27
>+++ pcibus.c    1997/01/08 06:25:35
>@@ -519,7 +519,7 @@
>        if (! (*maskptr & mask))
>                return (-1);
> 
>-       *maskptr &= ~mask;
>+       INTRUNMASK(*maskptr,mask);
>        update_intr_masks();
> 
>        return (0);
>

The code is certainly inconsistent.  I think the INTR*MASK macros should
go away.  They just obfuscate a C idiom.

Bruce