From owner-freebsd-current@FreeBSD.ORG Thu May 28 19:18:12 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B814D277; Thu, 28 May 2015 19:18:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 56636785; Thu, 28 May 2015 19:18:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wgbgq6 with SMTP id gq6so44799533wgb.3; Thu, 28 May 2015 12:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=GKf/X+Rhxq9T9HJi4MNVUla92JWo2MoxYspj2q8o8pE=; b=orgg4lb2hlwYS/RGwYG3A3a95Dwtu+YGfQl2r9UOI3E8zxxRPbuv8NOwEHUWmBR/r7 p7UL3fxB7WlbWTl12MmydPi8CxgMnVeQjvTHBA72TVAyuoi7yHHwvX3EwMnf2ESCphws M//xlXPBkBsnxMt0exL7VioQRl1gX5MvX/OKKAFUvgbrmt4unHGfUcB4QB/RaTz2CYWn 2LkilJAJE2tvTZkuQgBnqbGhzPMxUxnyO5E4qvRcjaKqDLhAKaO3sbc/+oVx4t+/HJFp Mems1Zx6SDHIwp4zA6O+5j+Re40yqoqWNkjJXKYYVWU9Ny+kP+LGhAf5EW7R6PoITEbP ypQA== X-Received: by 10.195.13.113 with SMTP id ex17mr7890989wjd.17.1432840690672; Thu, 28 May 2015 12:18:10 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id o5sm214273wia.0.2015.05.28.12.18.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 12:18:09 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 28 May 2015 21:18:07 +0200 From: Baptiste Daroussin To: Craig Rodrigues Cc: Johannes Jost Meixner , freebsd-current Current , "freebsd-testing@freebsd.org" Subject: Re: Need help reducing compilation warnings in CURRENT Message-ID: <20150528191806.GB70327@ivaldir.etoilebsd.net> References: <55670C5A.6080500@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 19:18:12 -0000 --LyciRD1jyfeSSjG0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner > wrote: >=20 > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Hi Craig, > > > > I'll gladly help (good excuse to learn C), but looking at those errors > > in general, one thing pops out: > > > > The warnings are almost all in contrib/ areas. Hence, any fix might > > want to probably be submitted to upstream first. > > >=20 >=20 > Sure, if we can push fixes upstream that would be great. > However, we shouldn't let that block us from comitting fixes to FreeBSD. > The advantage of having code in the FreeBSD repo is that we can > change it if we need to, even if the fix isn't yet in the upstream source= s. > Contrib code is not made out of stone that can't be modified! >=20 If not upstreamed, there is a good chance it get lost during the next updat= e. So in the special case of warning fixes, I would strongly advice to upstream first!! Best regards, Bapt --LyciRD1jyfeSSjG0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVnae4ACgkQ8kTtMUmk6ExZ2wCdFxVanUstn/epGAk8PsFt4uHI dnUAn2WUKTTX2ObLbG7Kq3ziMVI1wyYD =X+Va -----END PGP SIGNATURE----- --LyciRD1jyfeSSjG0--