From nobody Tue May 27 17:54:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b6Kyk3j9nz5xhkL; Tue, 27 May 2025 17:54:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b6Kyj1ZW1z3jl3; Tue, 27 May 2025 17:54:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748368477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H2kNC65J/GN1ZbjxrLxPBgGJZKaCt2cZhrJAjrY7C8Y=; b=xCip+L/KvTfOtuR8g59mWWkQJ0wwDpzipkvG8cFtPirbVNbdw6yhSZS3iJ1ozRk22EIQQT J1HXSBgNgQgY1uauxnmrJecQg2tw2cmOmGlLH1V3g74x1Mrt9X7i7JjY8htXcRNRUinTqB VS4HfHWzZ5eWnOjHs7JshTTLligj8dc4SkkRW5hxSp0B9gUtnN1Ezdxm0V4D18uSAHcZM/ SA/Z+zmPD8O/u1/kUY31/ZQ+QsTBZOpC0whQN+TsXY6+qoIOA4LivWN0CDRr5i5Ed4KSVj DXONFWKlAym0byQSU7vf68uzyEpd6XVx25uh+VVT++x+hCSAvF1VxA9WMtyfNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748368477; a=rsa-sha256; cv=none; b=cdDcsFFQLA9ny8l/D06gQVkMMb+n/b4kBiag5HlwvOA0IMVarVKtn3bno4+F0LrRihHd6W aKIWZB/Tzz9reIbpvwtcZ1AaxQAJUzZiHkGYpYntqQG3uWP/2K7c1iP4N3CMPwuPPitM6y IrQ2sAbag2P0zHHbcP6Ne5RxfMuSnxLk6EDWRjDjsuzOhSHRShPu2ykkkKSbcFNZ8L9tVJ prpnEt88hnWckLFRQCUDM+qWf5q3/r8QPe6SuapIPmgbh30+ZEy2pMm22AFVOsXB+skmkn DUQ+zBM1C/AkmE00G+pA/y7ViubZ9P+P7pBirPAOLEb1Ysiq1uYGRQv7ZG9+3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748368477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H2kNC65J/GN1ZbjxrLxPBgGJZKaCt2cZhrJAjrY7C8Y=; b=tt50HIqgbGlCVxkjzD8neoeFy6i9YQT+i1U+mouu2Auuy4c20+f9psuYxrVKH1goV5WZV5 eNoCeqrZ+P7LadNsxSs/4vBhICAUtxDufSVuFdtwrUHPe80WlefIXZzG3J03/LwNDDX7ZL yLB2SRi1pDgYlety5eQK9KXdG76Geq9ttqxgKY+f23S2CM3QV5TCaAsIbDjRcUyM219/Lw OXQwqaZPNco5rGgUb1iXcvc+YyN2eu/+GNnf5Iuqifo/1DfDfCWV8XZ/CkLngPMdbe5uEQ sQzjt1H1VdEWJfVqeGiWUc7ORfQVqYv5JXCidxoOqujl4cA34xtN/hWel5RdWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b6Kyj0lk5z12Mr; Tue, 27 May 2025 17:54:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54RHsaCV003675; Tue, 27 May 2025 17:54:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54RHsa0H003672; Tue, 27 May 2025 17:54:36 GMT (envelope-from git) Date: Tue, 27 May 2025 17:54:36 GMT Message-Id: <202505271754.54RHsa0H003672@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 731c145612dd - main - e1000: Fix some issues in em_newitr() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 731c145612dd6ffe457a562959a5c027acf13334 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=731c145612dd6ffe457a562959a5c027acf13334 commit 731c145612dd6ffe457a562959a5c027acf13334 Author: Mark Johnston AuthorDate: 2025-05-27 17:08:07 +0000 Commit: Mark Johnston CommitDate: 2025-05-27 17:33:39 +0000 e1000: Fix some issues in em_newitr() - Load packet and byte counters exactly once, as they can be concurrently mutated. - Rename bytes_packets to bytes_per_packet, which seems clearer. - Use local variables that have the same types as the counter values, rather than truncating unsigned long to u32. Reviewed by: kbowling MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D50416 --- sys/dev/e1000/if_em.c | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 27500f936c25..f0ef6051fab1 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -1644,14 +1644,16 @@ em_newitr(struct e1000_softc *sc, struct em_rx_queue *que, struct tx_ring *txr, struct rx_ring *rxr) { struct e1000_hw *hw = &sc->hw; + unsigned long bytes, bytes_per_packet, packets; + unsigned long rxbytes, rxpackets, txbytes, txpackets; u32 newitr; - u32 bytes; - u32 bytes_packets; - u32 packets; u8 nextlatency; + rxbytes = atomic_load_long(&rxr->rx_bytes); + txbytes = atomic_load_long(&txr->tx_bytes); + /* Idle, do nothing */ - if ((txr->tx_bytes == 0) && (rxr->rx_bytes == 0)) + if (txbytes == 0 && rxbytes == 0) return; newitr = 0; @@ -1671,18 +1673,20 @@ em_newitr(struct e1000_softc *sc, struct em_rx_queue *que, goto em_set_next_itr; } - bytes = bytes_packets = 0; + bytes = bytes_per_packet = 0; /* Get largest values from the associated tx and rx ring */ - if (txr->tx_bytes && txr->tx_packets) { - bytes = txr->tx_bytes; - bytes_packets = txr->tx_bytes/txr->tx_packets; - packets = txr->tx_packets; + txpackets = atomic_load_long(&txr->tx_packets); + if (txpackets != 0) { + bytes = txbytes; + bytes_per_packet = txbytes / txpackets; + packets = txpackets; } - if (rxr->rx_bytes && rxr->rx_packets) { - bytes = max(bytes, rxr->rx_bytes); - bytes_packets = - max(bytes_packets, rxr->rx_bytes/rxr->rx_packets); - packets = max(packets, rxr->rx_packets); + rxpackets = atomic_load_long(&rxr->rx_packets); + if (rxpackets != 0) { + bytes = lmax(bytes, rxbytes); + bytes_per_packet = + lmax(bytes_per_packet, rxbytes / rxpackets); + packets = lmax(packets, rxpackets); } /* Latency state machine */ @@ -1692,7 +1696,7 @@ em_newitr(struct e1000_softc *sc, struct em_rx_queue *que, break; case itr_latency_lowest: /* 70k ints/s */ /* TSO and jumbo frames */ - if (bytes_packets > 8000) + if (bytes_per_packet > 8000) nextlatency = itr_latency_bulk; else if ((packets < 5) && (bytes > 512)) nextlatency = itr_latency_low; @@ -1700,14 +1704,14 @@ em_newitr(struct e1000_softc *sc, struct em_rx_queue *que, case itr_latency_low: /* 20k ints/s */ if (bytes > 10000) { /* Handle TSO */ - if (bytes_packets > 8000) + if (bytes_per_packet > 8000) nextlatency = itr_latency_bulk; else if ((packets < 10) || - (bytes_packets > 1200)) + (bytes_per_packet > 1200)) nextlatency = itr_latency_bulk; else if (packets > 35) nextlatency = itr_latency_lowest; - } else if (bytes_packets > 2000) { + } else if (bytes_per_packet > 2000) { nextlatency = itr_latency_bulk; } else if (packets < 3 && bytes < 512) { nextlatency = itr_latency_lowest;