From owner-freebsd-hackers@FreeBSD.ORG Tue Jun 14 02:56:46 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1292616A41C for ; Tue, 14 Jun 2005 02:56:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (vc4-2-0-66.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC3AD43D49 for ; Tue, 14 Jun 2005 02:56:45 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.3/8.13.1) with ESMTP id j5E2tGX4000252; Mon, 13 Jun 2005 20:55:16 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 13 Jun 2005 20:56:22 -0600 (MDT) Message-Id: <20050613.205622.117024773.imp@bsdimp.com> To: joerg@britannica.bec.de From: "M. Warner Losh" In-Reply-To: <20050613162743.GA769@britannica.bec.de> References: <20050613124427.GD1343@britannica.bec.de> <200506131758.25671.hselasky@c2i.net> <20050613162743.GA769@britannica.bec.de> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org Subject: Re: Obvious bug in /sys/i386/include/bus.h X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2005 02:56:46 -0000 In message: <20050613162743.GA769@britannica.bec.de> Joerg Sonnenberger writes: : The compiler can only optimize it away if it is known to be a constant. : But thinking again about it, it should be documented at least whether : a count of 0 is allowed or not. I think it makes more sense to not allow : it, but others (you included) might disagree. I'd be happy with commitable bus_space.9, reguardless of how this discussion turns out. Warner