From owner-svn-src-all@freebsd.org Fri Feb 15 17:22:32 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34DC614E1A4E; Fri, 15 Feb 2019 17:22:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F17372E1D; Fri, 15 Feb 2019 17:22:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x643.google.com with SMTP id bj4so5249885plb.7; Fri, 15 Feb 2019 09:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1Q+hkS+BTHvnWwbp8kTKpSj1mjo731kNpyVGcj2JmtU=; b=kdq5eBe7t9VhFcDp758n4qNudnoZU/fTwXyGeJ+uPBeAe6tssKc+vL2GfZmmKJj2LH Qugc5gG/AUxjPDC1Ag0Ul+p9FyRoSsYfJTJZ5qdDlzeDuATGv5shQRrzj3+w4QyYXS/E NhsRa79JVtUWEyJlXL9jAGZ+l4Mcbd+JMTI0thdXyfWfwI7E3GnsLU/VkMYZCbaj4ycN rJ7HunXQsvOognih3CaCzRUNaa7dlqaBzmgx6V1jhjFe7f5DZBu+rWEQ3675nwFG2fck PyMkYN/HyhLZiZFCI930DFf90Pg+HZ04iF4/zH0hxGVT1esYyC57oYHppft8tlvWdRLE YxuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1Q+hkS+BTHvnWwbp8kTKpSj1mjo731kNpyVGcj2JmtU=; b=UW1JMaRvsKZtkQa86ml/2/hWTSSUouJQUDIIMaEjy8BkypIUqhqszBr/bzshIqCD7X f/EIivQUCjur9p2+o0fNgo1XpAQRFjoLBMCTLabJ6H5Xc+0BjU4Np29sGR8Ch9I969X5 CCqeqEG0mZR44zkRi4LYrxpncaqWxXAw3c3LYenWmzDWPef6SesOp35oUbS3sp6418Ml hTU9/MH9mbhENij85SqgbIabIP2R7wUpUGT9efIntrB9cJW9/KLhxTICspnqQR+837FD 2P5wXZrNv/H1f0sJt271jji9qg+iJu66haeFLPb5IvnDDfi8VD8NWvWr9XChb1M5dieU UEmA== X-Gm-Message-State: AHQUAubpCr8XK8733JZuy5Bal+4eOB7ynwkEMMvfXuXiVzDx6fkNmY+x eZzNZfoQs4ypQtCWY73s/APBKrM1 X-Google-Smtp-Source: AHgI3IZophNrfz7jCKLJgFbC/5CCGwjBXWHDS1oVm479NGh7UQkIaeztmz6OzaSUQfSH5lTUdwypzQ== X-Received: by 2002:a17:902:8c8b:: with SMTP id t11mr11319344plo.163.1550251349784; Fri, 15 Feb 2019 09:22:29 -0800 (PST) Received: from ?IPv6:2607:fb90:fc2:1b9f:4026:a8e0:25e5:211b? ([2607:fb90:fc2:1b9f:4026:a8e0:25e5:211b]) by smtp.gmail.com with ESMTPSA id l2sm7278164pgn.52.2019.02.15.09.22.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 09:22:29 -0800 (PST) Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r344129 - head From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: Date: Fri, 15 Feb 2019 09:22:27 -0800 Cc: "Rodney W. Grimes" , Mark Johnston , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <3415ED8D-6831-4EAA-97DB-7E45185E8B82@gmail.com> References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> To: Warner Losh X-Rspamd-Queue-Id: 9F17372E1D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_SHORT(-0.95)[-0.955,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 17:22:32 -0000 > On Feb 14, 2019, at 19:08, Warner Losh wrote: >=20 >> On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: >> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < >> > > > > Differential Review: https://reviews.freebsd.org/D19193 >> > > > >> > > > You sited a differential, but not give any attribution >> > > > to the external source :-( >> > > > >> > >=20 >> > > The differential review has that information. >> >=20 >> > External contributors should be recognized by having their names appear= >> > in the commit logs. >>=20 >> We even bother to put a special line in the commit template >> for this. Further it has been standard operating procedure >> for at least as long as I have been back that submitters >> are infact recognized in commit messages. >>=20 >> You have, again, summarily dismissed valid feedback. >=20 >=20 > The problem is that was a trivial commit. And you offered not one, but two= complaints about adding an 'e' to the updating file. That's what pissed me o= ff. It's advice that might be correct, but was so far over the top, in publi= c, for such a trivial commit. That's why I got mad: it added no value and se= emed nit picky and pretty. So I lost it. I shouldn't have, but I did.=20 >=20 > I'm sorry for my cool. Thank you both Rod and Warner for the reply. Thank you Rod for noting that src-committers was a public list; I thought it= was private to FreeBSD src committers. I replied to this thread because while I agree with what you said, I felt th= at the reaction and forum were not in proportion to what happened :/. More than a handful of threads lately have become heated to a point that con= cerns me about inter-developer relations and perception outside of the commu= nity. I have taken part in some of the discussions, potentially contributing= to the overall issue. I=E2=80=99m happy with the eventual outcome, but I hope that we, as a group,= can do better next time to avoid these situations and be kinder to one anot= her. Many of the recent issues (while important in aggregate) seem minor (in= disaggregate). All the best, -Enji=