From owner-freebsd-hackers@FreeBSD.ORG Thu Jun 30 13:32:20 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAC6A16A41C for ; Thu, 30 Jun 2005 13:32:20 +0000 (GMT) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F05D43D4C for ; Thu, 30 Jun 2005 13:32:20 +0000 (GMT) (envelope-from max@love2party.net) Received: from p54A3E725.dip.t-dialin.net [84.163.231.37] (helo=donor.laier.local) by mrelayeu.kundenserver.de with ESMTP (Nemesis), id 0MKwtQ-1Dnz9O2CpK-0005Li; Thu, 30 Jun 2005 15:32:18 +0200 From: Max Laier To: freebsd-hackers@freebsd.org Date: Thu, 30 Jun 2005 15:32:10 +0200 User-Agent: KMail/1.8 References: <000d01c57cf7$b9b6f9f0$29931bd9@ertpc> <200506301415.38106.max@love2party.net> In-Reply-To: <200506301415.38106.max@love2party.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5186526.3QMbNfkO8T"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200506301532.16330.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: ant Subject: Re: hot path optimizations in uma_zalloc() & uma_zfree() X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2005 13:32:20 -0000 --nextPart5186526.3QMbNfkO8T Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 30 June 2005 14:15, Max Laier wrote: > On Thursday 30 June 2005 00:08, ant wrote: > > @@ -2263,8 +2262,7 @@ > > if (bucket->ub_cnt < bucket->ub_entries) { > > KASSERT(bucket->ub_bucket[bucket->ub_cnt] =3D=3D NULL, > > ("uma_zfree: Freeing to non free bucket index.")); > > - bucket->ub_bucket[bucket->ub_cnt] =3D item; > > - bucket->ub_cnt++; > > + bucket->ub_bucket[bucket->ub_cnt++] =3D item; > > This changes semantics, as far as I understand. Might be a consequence of > the other work you are doing, but doesn't seem right from a first glance. Ignore that, I was reading things backward - sorry for the noise. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart5186526.3QMbNfkO8T Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCw/RgXyyEoT62BG0RAiIzAJ9hXHpyKAxNI1uu4QIRHLnvVWacPgCfWFNT VGQb3sGFbbNGlVwiWqVbOGE= =vQUx -----END PGP SIGNATURE----- --nextPart5186526.3QMbNfkO8T--