Date: Thu, 30 Jun 2005 15:32:10 +0200 From: Max Laier <max@love2party.net> To: freebsd-hackers@freebsd.org Cc: ant <andrit@ukr.net> Subject: Re: hot path optimizations in uma_zalloc() & uma_zfree() Message-ID: <200506301532.16330.max@love2party.net> In-Reply-To: <200506301415.38106.max@love2party.net> References: <000d01c57cf7$b9b6f9f0$29931bd9@ertpc> <200506301415.38106.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart5186526.3QMbNfkO8T
Content-Type: text/plain;
charset="iso-8859-6"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Thursday 30 June 2005 14:15, Max Laier wrote:
> On Thursday 30 June 2005 00:08, ant wrote:
> > @@ -2263,8 +2262,7 @@
> > if (bucket->ub_cnt < bucket->ub_entries) {
> > KASSERT(bucket->ub_bucket[bucket->ub_cnt] =3D=3D NULL,
> > ("uma_zfree: Freeing to non free bucket index."));
> > - bucket->ub_bucket[bucket->ub_cnt] =3D item;
> > - bucket->ub_cnt++;
> > + bucket->ub_bucket[bucket->ub_cnt++] =3D item;
>
> This changes semantics, as far as I understand. Might be a consequence of
> the other work you are doing, but doesn't seem right from a first glance.
Ignore that, I was reading things backward - sorry for the noise.
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--nextPart5186526.3QMbNfkO8T
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQBCw/RgXyyEoT62BG0RAiIzAJ9hXHpyKAxNI1uu4QIRHLnvVWacPgCfWFNT
VGQb3sGFbbNGlVwiWqVbOGE=
=vQUx
-----END PGP SIGNATURE-----
--nextPart5186526.3QMbNfkO8T--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506301532.16330.max>