From owner-svn-ports-all@freebsd.org Thu Jul 26 07:02:31 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59B151044A55; Thu, 26 Jul 2018 07:02:31 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id E1A3D81B0F; Thu, 26 Jul 2018 07:02:30 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w6Q72TID056768 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 26 Jul 2018 00:02:29 -0700 (PDT) (envelope-from yuri@freebsd.org) X-Authentication-Warning: shell1.rawbw.com: Host c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me Reply-To: yuri@freebsd.org Subject: Re: svn commit: r475335 - head/devel/liteide To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201807252025.w6PKPsxQ097871@repo.freebsd.org> <20180726064408.GC77261@FreeBSD.org> From: Yuri Message-ID: <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org> Date: Thu, 26 Jul 2018 00:02:27 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180726064408.GC77261@FreeBSD.org> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 07:02:31 -0000 On 7/25/18 11:44 PM, Alexey Dokuchaev wrote: >> ... >> +FLAVORS= qt5 qt4 >> +FLAVOR?= ${FLAVORS:[1]} > Is this line needed in this case? Section 7.2 of PHB recommends this line: https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html >> ... >> +.if ${FLAVOR} == qt4 >> +USES+= qt:4 >> +USE_QT= corelib gui moc_build network rcc_build uic_build webkit xml >> +PLIST_SUB+= QT4="" NO_QT4="@comment " >> +.else >> +USES+= qt:5 >> +USE_QT= buildtools_build core gui network printsupport widgets xml >> +PLIST_SUB+= QT4="@comment " NO_QT4="" >> +.endif > Because qt5 is default flavor, and you're checking for qt4 first (qt5 is > in .else branch) and never for .if ${FLAVOR} == qt5. Framework checks that flavor is in the list. Here, when flavor isn't qt4, it is safe to assume that it is qt5. Yuri