From owner-svn-src-all@FreeBSD.ORG Fri Jun 29 17:09:15 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52D60106564A for ; Fri, 29 Jun 2012 17:09:15 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm15.bullet.mail.sp2.yahoo.com (nm15.bullet.mail.sp2.yahoo.com [98.139.91.85]) by mx1.freebsd.org (Postfix) with SMTP id 0D0E68FC16 for ; Fri, 29 Jun 2012 17:09:15 +0000 (UTC) Received: from [98.139.91.69] by nm15.bullet.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:09:09 -0000 Received: from [98.139.91.42] by tm9.bullet.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:09:09 -0000 Received: from [127.0.0.1] by omp1042.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:09:09 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 23340.50402.bm@omp1042.mail.sp2.yahoo.com Received: (qmail 74577 invoked by uid 60001); 29 Jun 2012 17:09:08 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1340989748; bh=UbCf8UXXvvWXgK70ZEdFIizRcSEsjw9ueKNQVIjceL4=; h=X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=LwN1Uyl3Wxwgu/AF30BGGDwVyuQEWMm5lQJZJSxepZrSYemh3UuByltY3LwlQ0P3LjN3G9rdjjE1fqQL1gWQGBuucmCl1l4MJWmNl7juRgZl9IfBZoFgIjce5lb3vQW1P8nHctuXaQbGs9fhAFgWPlHLBhX6xQYtJpYKEZcrzF0= X-YMail-OSG: mMhv.6IVM1lJX_9_6oGmO9svJ0DRx_uSOaLLp9qPtqoqedg _8wdpdfKZitlFUp4dpMsKg8hnoe6jN3GKFpK2lc41Ch72dywAluyGfPLk8sd vRzj8h5EDi.XPrBdgeGs6vEs6uYr9IWKCs8ZiTCuZoi7SQRgGVVk_f84VQbD iYAcW0ju86MQ7tTVqzZb1XiQaSlUoivAITfLRA1YOzBoXjKSzlLOaXpwcenp q42CujW57gPGbrleRmo4qx0rk1hDMtVoYjmp_p7vNhQ2zSwoJZh2BKOhK.a_ tcAakFrGMOb4Ks0b92x8BbaUsNMPKDNP5vqqu.ar24HQTPveJag.Y6uF9Zko dSe6WNwgZISJOYzJwdDDfy3OUVZPIopr.vn2WyFOI5q2K.H8ioZSsR.lI3Bh urMV9KKLBKB0Cl3KgIV_bMGEZ0_ecH5WdDYmMgGEBG3CTxBDLcjO4kWZtKen PfByQjhuli5I_ofAeLLlvh0VIklJ.IGXPobdXkbBEzGpGbipfCdxz6ZQDOBt p9JIyhQeAwCPRfeqyUamifI7j0XGBaEteBTVaKCaHcjFOmOsLaowa_gkkvky XFQLY3GFtaitK2saFj4o- Received: from [200.118.157.7] by web113504.mail.gq1.yahoo.com via HTTP; Fri, 29 Jun 2012 10:09:08 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/15.0.8 YahooMailWebService/0.8.118.349524 Message-ID: <1340989748.73663.YahooMailClassic@web113504.mail.gq1.yahoo.com> Date: Fri, 29 Jun 2012 10:09:08 -0700 (PDT) From: Pedro Giffuni To: obrien@FreeBSD.org In-Reply-To: <20120629152109.GA70522@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pfg@freebsd.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 17:09:15 -0000 Hi David;=0A=0A--- Ven 29/6/12, David O'Brien ha scrit= to:=0A...=0A> ...=0A> > +/*=0A> > + * Copyright (c) 2011, Joyent, Inc. All = rights=0A> reserved.=0A> > + */=0A> =0A> Pedro,=0A> It looks like you simpl= y 'svn add'ed this file, rather than=0A> importing it into '^/vendor/openso= laris/dist'.=A0 =0A> Please correct me if I am wrong.=0A> =0A=0AYou are abs= olutely right. However I am not sure we should=0Abring Illumos enhancements= under the opensolaris vendor=0Abranch. The reason is that this files are C= DDL'd but are=0Athere was no property assignment done to the OpenSolaris=0A= copyright owner. [1]=0A=0AIf somehow Oracle decides to relicense Dtrace or = ZFS we=0Astill must keep these changes isolated from the code=0Aprovided in= the vendor branch.=0A=0A=0A> We've become rather sloppy in the past 1-2 ye= ars in our=0A> handling of 3rd-party externally developed code.=A0 Somethin= g=0A> we need to return to our older ways good ways of handling.=0A> =0A=0A= Yes, that is true.=0A=0AI think we have to decide if we are going to consid= er=0AIllumos a vendor on it's own. For ZFS it would seem=0Athe right thing = to do, for Dtrace I am not sure: at=0Aleast I am not considering bringing a= ny other feature=0Aat this time.=0A=0A=0AThank you for the links on Code Pr= ovenance Review.=0A=0A> =0A> Please correct this by properly importing the = sources, 'svn=0A> delete'ing the files you 'svn add'ed, and do an 'svn copy= '=0A> of the new files.=0A>=0A=0AI think the discussion is indeed important= enough to=0Asuspend the MFC I was planning and if desired I can=0Aalso rev= ert the commit.=0A=0APedro.=0A=0A=0A[1] http://smartos.org/2011/12/15/fork-= yeah-the-rise-and-development-of-illumos-2/