From owner-freebsd-stable@freebsd.org Sun Jun 17 17:27:59 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67898100309D for ; Sun, 17 Jun 2018 17:27:59 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D11147692F for ; Sun, 17 Jun 2018 17:27:58 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-wm0-x22a.google.com with SMTP id l15-v6so12319197wmc.1 for ; Sun, 17 Jun 2018 10:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xw1yRy9XmOZM9RhDz3gmlGEvxU4XN4mWhUy1SMsM/bI=; b=bsFaaL9doybVfaUEDTgQTQ4kzxkxNJmAmQ89BvyW5az6zaWENZC10UhHkybiJPN1ht F+PXaRyRmIZXWeRIjZFa3j8qzejRELlbfW3ap+noil9POBFIh4U0z/+qfixwyDv9WNtN 5C0kBNlUP3nXAoNFxKPaSoqyOV08hX4JZKrUn7/aIW+smoPiuEGdmv8CGMsySfbvodA/ N+clQXgocBqvqi2+d1W8AcGHH+MxGpl315mNHumQpePdBu4bZgaaCTz87aaCP2jMELuo 4nVAFRxGoxm1oxzmi2rfLLzSC2C1gyPwW2iovshAjzJOgCRNprTvsBHPyr/61CjPYOUc m17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xw1yRy9XmOZM9RhDz3gmlGEvxU4XN4mWhUy1SMsM/bI=; b=YsOQRO73lheNp02SCL+SJCX55xrvc2M2/ElT9xyEWik76iy2BXVUuFvoxwErG/Meo+ rhmPB96kEfsS5nLDpr80Pox6GPmhBrDdkSGfVUwetiQwfpg4pJ+IB4M9bIgdgoQ46sAA h9jh8inx6R8Rf3GtzTCQgZa8jCEzT96CoZD2WzqD6ZhGl2V0CoogK+gsTkpA5BON6lm3 9EOm8g5JVd5jURKExxYPe46JUWvNVpsXTh1KGIAF2bTzYQ+eeieDeQuIr9GdlwJYKEpd nu3inM7X9VT1nBEbN+o1Qc3xRlN+KycMLn5I5yVtBLZoibPEWAyl7M0dedPFcZJCk2t7 oshg== X-Gm-Message-State: APt69E1bwyk8wqvFC6sVebEKEUZxV5ZllATz9OFGqT40HhbtKTJBV/n5 dJ+uMu2BvYmQSthDPx3qbric0xWW6YdCk4V+O9AF2w== X-Google-Smtp-Source: ADUXVKL8rniVCLgsxhVL/2fG1OfsYQCpe8mtpLJFF7r0r0efnMcpG1NtaT/XKnvjKRF/HYXMqa8Fp3fgIB6iIHsSIm4= X-Received: by 2002:aa7:d3cb:: with SMTP id o11-v6mr8645462edr.104.1529256476303; Sun, 17 Jun 2018 10:27:56 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:8e0d:0:0:0:0:0 with HTTP; Sun, 17 Jun 2018 10:27:25 -0700 (PDT) In-Reply-To: References: From: Ed Schouten Date: Sun, 17 Jun 2018 19:27:25 +0200 Message-ID: Subject: Re: syslogd became silent between 11.2-PRERELEASE r334874 and r335282 To: Michael Grimm Cc: FreeBSD-STABLE Mailing List , "ed@FreeBSD.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 17:27:59 -0000 Hi Michael, 2018-06-17 17:52 GMT+02:00 Michael Grimm : > I do believe that this commit might be the cause: > https://svnweb.freebsd.org/base/stable/11/usr.sbin/syslogd/Makefile?revision=335059&view=markup&sortby=file Thanks for reporting this issue. I just did some debugging on my system and I think I was able to reproduce this issue. It seems as if I made a tiny mistake in how I implemented the RFC 5426 UDP message size limiting. Could you please give the following patch for syslogd a try? Index: usr.sbin/syslogd/syslogd.c =================================================================== --- usr.sbin/syslogd/syslogd.c (revision 334706) +++ usr.sbin/syslogd/syslogd.c (working copy) @@ -1613,8 +1613,8 @@ struct iovec *last; size_t diff; - while (size > il->totalsize) { - diff = size - il->totalsize; + while (il->totalsize > size) { + diff = il->totalsize - size; last = &il->iov[il->iovcnt - 1]; if (diff >= last->iov_len) { /* Remove the last iovec entirely. */ It should be sufficient to apply this to just the 'client' syslogd. There is no need to patch the central (storage) server. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands