Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 06 Nov 2017 10:04:38 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 223108] [PATCH] www/uwsgi: Add support for non-default Python versions, Take MAINTAINER'ship
Message-ID:  <bug-223108-13-0vH9rI0J4l@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-223108-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-223108-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223108

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koobs@FreeBSD.org,
                   |                            |python@FreeBSD.org,
                   |                            |schmidt@ze.tum.de
              Flags|                            |maintainer-feedback?(schmid
                   |                            |t@ze.tum.de)
            Summary|[PATCH] www/uwsgi added     |[PATCH] www/uwsgi: Add
                   |support for building uwsgi  |support for non-default
                   |with a different python     |Python versions, Take
                   |version than the default    |MAINTAINER'ship
                   |and takeing over            |
                   |maintainership of this      |
                   |port.                       |
             Status|New                         |Open
           Keywords|patch                       |needs-patch, needs-qa

--- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thank you for your contribution Gerhard.

The attached patch needs changes, but I don't have time for a full review
tonight.

Please run the port through portlint -AC and poudriere with DEVELOPER=3Dyes
enabled, and submit an updated patch which addresses any issues identified.=
 For
testing information and instructions, see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.=
html

Above that, some obvious issues:

- Remove PYTHON_PKGNAMEPREFIX from PORTNAME. For correct usage see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm=
l#using-python

- Use CHEESESHOP as MASTER_SITES by default unless there's a compelling
temporary reason not to (eg: alternate source contains test files/test data)

- Use USE_PYTHON=3Dautoplist
- Use USE_PYTHON=3Dconcurrent to do automatic suffixing of console scripts
installed in LOCALBASE/bin

These are both documented in the link above as well.

- Explain the gettext-runtime addition

Lastly, thank you for offering to take maintainership of a FreeBSD port

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-223108-13-0vH9rI0J4l>