From owner-freebsd-current Wed Nov 5 22:50:01 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id WAA24429 for current-outgoing; Wed, 5 Nov 1997 22:50:01 -0800 (PST) (envelope-from owner-freebsd-current) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (8.8.7/8.8.7) with SMTP id WAA24372 for ; Wed, 5 Nov 1997 22:49:45 -0800 (PST) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id GAA24505; Thu, 6 Nov 1997 06:37:40 +0100 From: Luigi Rizzo Message-Id: <199711060537.GAA24505@labinfo.iet.unipi.it> Subject: Re: attach_mss for full duplex: possible misspelling? To: kushnir@ap3.gluk.apc.org (Vladimir Kushnir) Date: Thu, 6 Nov 1997 06:37:39 +0100 (MET) Cc: freebsd-current@FreeBSD.ORG In-Reply-To: from "Vladimir Kushnir" at Nov 6, 97 02:24:02 am X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Sorry, perhaps I'm just plainly stupid but isn't there a misspelling in an > attach_mss routine (new sound driver, sound/ad1848.c, lines 1724-1725)? It > calls ad1848_init like > > ad1848_init("MS Sound System0", hw_config->io_base + 4, > hw_config->irq, > hw_config->dma, > hw_config->dma, 0, hw_config->osp); > } > > (with both dma equal). Should not it spell > ... > hw_config->dma, > hw_config->dma2, > ... instead? At least, this way it initializes my card (CS4231 based > Yamaha OPL3 PnP duplex card) correctly. of course you can try, but the AD1848 and some clones have only 1 DMA channel, and I believe the code is not enough informed to know which card it is attaching. BTW the Yamaha as far as I know is not based on the CS4231 -- it uses a proprietary chip which _emulates_ some features of the CS423x but has some differences (e.g. a master volume control using separate registers). Cheers Luigi