From owner-svn-src-all@FreeBSD.ORG Fri Mar 13 21:22:34 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 093511065674; Fri, 13 Mar 2009 21:22:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 9D4588FC1B; Fri, 13 Mar 2009 21:22:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LiEps-000E0Q-58; Fri, 13 Mar 2009 23:22:32 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n2DLMTig037377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 13 Mar 2009 23:22:29 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n2DLMTN7014353; Fri, 13 Mar 2009 23:22:29 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n2DLMTHn014352; Fri, 13 Mar 2009 23:22:29 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 13 Mar 2009 23:22:29 +0200 From: Kostik Belousov To: John Baldwin Message-ID: <20090313212229.GW41617@deviant.kiev.zoral.com.ua> References: <200812181158.mBIBwC50039690@svn.freebsd.org> <49BAA2C6.2000807@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2UfnThGAjlIhdWh/" Content-Disposition: inline In-Reply-To: <49BAA2C6.2000807@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LiEps-000E0Q-58 b8427aac06b2da6619ebe8da2d82be47 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186276 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2009 21:22:35 -0000 --2UfnThGAjlIhdWh/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2009 at 02:15:34PM -0400, John Baldwin wrote: > Konstantin Belousov wrote: > >Author: kib > >Date: Thu Dec 18 11:58:12 2008 > >New Revision: 186276 > >URL: http://svn.freebsd.org/changeset/base/186276 > > > >Log: > > Do not return success and doomed vnode from lookup. LK_UPGRADE allows > > the vnode to be reclaimed. > > =20 > > Tested by: pho > > MFC after: 1 month >=20 > Would EBADF be more appropriate? That is what other places that check=20 > VI_DOOMED return for this type of check (e.g. in cache_lookup()). I do not think so. When we do namei lookup, there is actually no file descriptor to be invalid. The fact the we lost the race with forced unmount actually means that there is no more node with supplied name. --2UfnThGAjlIhdWh/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkm6zpQACgkQC3+MBN1Mb4hx2ACgj4wTci0VmNugCYOeh1gBMCza M3IAoNDpUMKztX5lFK8cZm2g9Rv8MxnA =qyS1 -----END PGP SIGNATURE----- --2UfnThGAjlIhdWh/--