From owner-svn-src-head@freebsd.org Sat May 19 16:49:40 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B22AAEDA042; Sat, 19 May 2018 16:49:40 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5E47976192; Sat, 19 May 2018 16:49:40 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com [209.85.214.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 21F2825338; Sat, 19 May 2018 16:49:40 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f44.google.com with SMTP id q4-v6so16816595ite.3; Sat, 19 May 2018 09:49:40 -0700 (PDT) X-Gm-Message-State: ALKqPwd0eO8JKhB/Sy1PyfamwmDj1N0k+EuPQkrh0zi/YsSsQrz2Gw4j j/rdKCuyvXpA/UrhuQa70GoEu1/BpkNtKMz5u60= X-Google-Smtp-Source: AB8JxZpusEUQrXo7u1PAiXLpOJlfuxAXTK/Q8ezBDadRULqxyndph/8ccIkmt5MrXjeS7bSewYwDUaAr9kx8K4zDyBs= X-Received: by 2002:a24:5b54:: with SMTP id g81-v6mr11431156itb.7.1526748579496; Sat, 19 May 2018 09:49:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ae:0:0:0:0:0 with HTTP; Sat, 19 May 2018 09:49:39 -0700 (PDT) In-Reply-To: References: <201805190004.w4J0419B099140@repo.freebsd.org> From: Matthew Macy Date: Sat, 19 May 2018 09:49:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter To: Ed Maste Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 16:49:41 -0000 As I suspected, we fix warnings on non-contrib code. These are only used on contrib code. -M mmacy@anarchy [~/devel/upstream|9:46|26] find sys | xargs grep NO_WSELF_ASS= IGN sys/modules/ipfilter/Makefile:CWARNFLAGS.fil.c=3D ${NO_WSELF_ASSIGN} -Wno-unused sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_lookup.c=3D ${NO_WSELF_ASSIGN} -Wno-unused sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_proxy.c=3D ${NO_WSELF_ASSIGN} -Wno-unused sys/conf/kern.mk:NO_WSELF_ASSIGN=3D -Wno-self-assign sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -I$S/contrib/ipfilter" sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -I$S/contrib/ipfilter" sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -Wno-error -I$S/contrib/ipfilter" mmacy@anarchy [~/devel/upstream|9:47|27] find sys | xargs grep NO_WSHIFT_COUNT_NEGATIVE sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=3D ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} sys/conf/kern.mk:NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath" mmacy@anarchy [~/devel/upstream|9:47|28] find sys | xargs grep NO_WSHIFT_COUNT_OVERFLOW sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=3D ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} sys/conf/kern.mk:NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath" On Sat, May 19, 2018 at 5:30 AM, Matthew Macy wrote: > Oops I=E2=80=99ll add a separate define for that > > On Sat, May 19, 2018 at 04:27 Ed Maste wrote: >> >> On 18 May 2018 at 20:04, Matt Macy wrote: >> > Author: mmacy >> > Date: Sat May 19 00:04:01 2018 >> > New Revision: 333819 >> > URL: https://svnweb.freebsd.org/changeset/base/333819 >> > >> > Log: >> > Silence non-actionable warnings in vendor code >> ... >> > Modified: head/sys/conf/kern.mk >> > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >> > --- head/sys/conf/kern.mk Fri May 18 23:42:08 2018 >> > (r333818) >> > +++ head/sys/conf/kern.mk Sat May 19 00:04:01 2018 >> > (r333819) >> > @@ -18,12 +18,13 @@ CWARNFLAGS?=3D -Wall -Wredundant-decls >> > -Wnested-externs >> > # a false positive. >> > .if ${COMPILER_TYPE} =3D=3D "clang" >> > NO_WCONSTANT_CONVERSION=3D -Wno-error-constant-conversion >> > -NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-error-shift-count-negative >> > -NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-error-shift-count-overflow >> > -NO_WSELF_ASSIGN=3D -Wno-error-self-assign >> > +NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative >> > +NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow >> > +NO_WSELF_ASSIGN=3D -Wno-self-assign >> >> This silences the warning across the tree, not just vendor code.