From owner-p4-projects  Sun Oct  6  7:22:30 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2CDA637B404; Sun,  6 Oct 2002 07:22:28 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8F14037B401
	for <perforce@freebsd.org>; Sun,  6 Oct 2002 07:22:27 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F116943E42
	for <perforce@freebsd.org>; Sun,  6 Oct 2002 07:22:26 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3])
	by fledge.watson.org (8.12.4/8.12.4) with SMTP id g96ELwOo006643
	for <perforce@freebsd.org>; Sun, 6 Oct 2002 10:21:59 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Sun, 6 Oct 2002 10:21:58 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 18806 for review
In-Reply-To: <200210061359.g96DxRk9014233@freefall.freebsd.org>
Message-ID: <Pine.NEB.3.96L.1021006102122.5871A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

My commit message wasn't quite accurate.  What we were not enforcing was
socket i/o via fo_read/fo_write -- we were enforcing sendfile(), send(),
recv(), etc.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories

On Sun, 6 Oct 2002, Robert Watson wrote:

> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18806
> 
> Change 18806 by rwatson@rwatson_tislabs on 2002/10/06 06:59:19
> 
> 	MAC checks in sys_socket.c will work much better if we include
> 	opt_mac.h.  We weren't enforcing file-descriptor driven sends
> 	and receives.
> 
> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/kern/sys_socket.c#16 edit
> 
> Differences ...
> 
> ==== //depot/projects/trustedbsd/mac/sys/kern/sys_socket.c#16 (text+ko) ====
> 
> @@ -34,9 +34,12 @@
>   * $FreeBSD: src/sys/kern/sys_socket.c,v 1.45 2002/10/03 02:12:58 truckman Exp $
>   */
>  
> +#include "opt_mac.h"
> +
>  #include <sys/param.h>
>  #include <sys/systm.h>
>  #include <sys/file.h>
> +#include <sys/mac.h>
>  #include <sys/protosw.h>
>  #include <sys/socket.h>
>  #include <sys/socketvar.h>
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message