From owner-freebsd-hackers Thu Dec 2 1: 9:50 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from post.mail.nl.demon.net (post-11.mail.nl.demon.net [194.159.73.21]) by hub.freebsd.org (Postfix) with ESMTP id 2FBD314C1C for ; Thu, 2 Dec 1999 01:09:45 -0800 (PST) (envelope-from marcel@scc.nl) Received: from [212.238.132.94] (helo=scones.sup.scc.nl) by post.mail.nl.demon.net with esmtp (Exim 2.12 #1) id 11tSCz-0000tf-00; Thu, 2 Dec 1999 09:07:25 +0000 Received: from scc.nl (scones.sup.scc.nl [192.168.2.4]) by scones.sup.scc.nl (8.9.3/8.9.3) with ESMTP id KAA34002; Thu, 2 Dec 1999 10:07:24 +0100 (CET) (envelope-from marcel@scc.nl) Message-ID: <384636CC.A184B6D0@scc.nl> Date: Thu, 02 Dec 1999 10:07:24 +0100 From: Marcel Moolenaar Organization: SCC vof X-Mailer: Mozilla 4.7 [en] (X11; I; Linux 2.2.5 i386) X-Accept-Language: en MIME-Version: 1.0 To: Alfred Perlstein Cc: Reinier Bezuidenhout , wilko@yedi.iaf.nl, groudier@club-internet.fr, FreeBSD-hackers@FreeBSD.ORG Subject: Re: Linux ioctl not implemented error References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > > > + if (!error) { > > + lvol = *lvolp; > > + lvol.channel0 = bsd_vol.vol[0]; > > + lvol.channel1 = bsd_vol.vol[1]; > > + lvol.channel2 = bsd_vol.vol[2]; > > + lvol.channel3 = bsd_vol.vol[3]; > > FYI the kernel structures are completely identical, you don't really > gain anything by doing this convertion. Should this be put in for > clarity? I'm not sure. No. When it's there, you automaticly assume it's there for a reason. Since the structures are identical, there's no reason for the code to be there. Very confusing :-) -- Marcel Moolenaar mailto:marcel@scc.nl SCC Internetworking & Databases http://www.scc.nl/ The FreeBSD project mailto:marcel@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message