From owner-freebsd-multimedia@FreeBSD.ORG  Fri Sep  5 13:35:42 2008
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8842B1065673
	for <freebsd-multimedia@freebsd.org>;
	Fri,  5 Sep 2008 13:35:42 +0000 (UTC)
	(envelope-from unixmania@gmail.com)
Received: from gv-out-0910.google.com (gv-out-0910.google.com [216.239.58.185])
	by mx1.freebsd.org (Postfix) with ESMTP id 175768FC1C
	for <freebsd-multimedia@freebsd.org>;
	Fri,  5 Sep 2008 13:35:39 +0000 (UTC)
	(envelope-from unixmania@gmail.com)
Received: by gv-out-0910.google.com with SMTP id n8so11840gve.39
	for <freebsd-multimedia@freebsd.org>;
	Fri, 05 Sep 2008 06:35:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to
	:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references;
	bh=up71UFc3xl6ov53wUkgfEM2WEMfpQb1pyQuChqHQA40=;
	b=pg00y4zrRT1p/pQpRKmJ+cGipCWDw4okPZJNRMT3DxJWCoZMaykB9r5kWjvC3FpydT
	q6zulXb90cTwErV7nYcCovaVPD5xrNZnzYAQDwmVzlOja3xI3FQv8E5iY0x0hzDxubT0
	WNikDo0e+V1Cnr9k80CSRFJHrIJYTPWo53kVg=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references;
	b=tp13C6MXx7BFkffdBplJdtCPM7ya+OOt6KtAl+bewjlJjHX8HyUJZzA4N6QcFFqDoJ
	e5QKVtEnITJyaxRCXk/cIjwU+6vuXmhAlrdfq2f6OMDikKdqLWWl7G8zPk864h1p8n++
	T3PXwqAKW4uupbPJP80YWUkrXcw18ocenypK4=
Received: by 10.103.248.17 with SMTP id a17mr7942621mus.63.1220621737729;
	Fri, 05 Sep 2008 06:35:37 -0700 (PDT)
Received: by 10.103.231.14 with HTTP; Fri, 5 Sep 2008 06:35:37 -0700 (PDT)
Message-ID: <e71790db0809050635u69bd0336j768b4efe734211a5@mail.gmail.com>
Date: Fri, 5 Sep 2008 10:35:37 -0300
From: "Carlos A. M. dos Santos" <unixmania@gmail.com>
To: frtzkatz@yahoo.com
In-Reply-To: <542052.24495.qm@web63007.mail.re1.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <542052.24495.qm@web63007.mail.re1.yahoo.com>
Cc: freebsd-multimedia@freebsd.org
Subject: Re: Is this a bug? (in /usr/src/sys/dev/bktr/bktr_os.c )
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Sep 2008 13:35:42 -0000

On Thu, Sep 4, 2008 at 9:59 PM, Fritz Katz <frtzkatz@yahoo.com> wrote:
> In FreeBSD-7.0, /usr/src/sys/dev/bktr/bktr_os.c, line 469:
>
> http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70#L469
> __________
>
> fail:
>  if (bktr->res_irq)
>     bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq);
>  if (bktr->res_mem)
>     bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem);
>  return error;
> __________
>
> Shouldn't the type field for the second bus_release_resource be SYS_RES_MEMORY?  Would it cause a kernel panic if it were ever hit?  If it is a bug, it's probably been there for years.

For sure it is a bug, since it is not in accordance with

http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70;im=excerpts#L347

-- 
cd /usr/ports/sysutils/life
make clean