From owner-cvs-all@FreeBSD.ORG  Thu Dec  1 17:30:59 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8826116A41F;
	Thu,  1 Dec 2005 17:30:59 +0000 (GMT) (envelope-from ru@ip.net.ua)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 25D5C43D4C;
	Thu,  1 Dec 2005 17:30:57 +0000 (GMT) (envelope-from ru@ip.net.ua)
Received: from localhost (rocky.ip.net.ua [82.193.96.2])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jB1HUutT018698;
	Thu, 1 Dec 2005 19:30:56 +0200 (EET) (envelope-from ru@ip.net.ua)
Received: from tigra.ip.net.ua ([82.193.96.10])
	by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new,
	port 10024) with LMTP
	id 82617-02-2; Thu,  1 Dec 2005 19:30:55 +0200 (EET)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jB1HRtEn018582
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 1 Dec 2005 19:27:55 +0200 (EET) (envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.13.4/8.13.4) id jB1HRvvF022965;
	Thu, 1 Dec 2005 19:27:57 +0200 (EET) (envelope-from ru)
Date: Thu, 1 Dec 2005 19:27:57 +0200
From: Ruslan Ermilov <ru@FreeBSD.ORG>
To: Warner Losh <imp@FreeBSD.ORG>
Message-ID: <20051201172757.GG20961@ip.net.ua>
References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="JbKQpFqZXJ2T76Sg"
Content-Disposition: inline
In-Reply-To: <200512011708.jB1H8u3Y065515@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
X-Virus-Scanned: by amavisd-new at ip.net.ua
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src Makefile.inc1
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2005 17:30:59 -0000


--JbKQpFqZXJ2T76Sg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
> imp         2005-12-01 17:08:56 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     .                    Makefile.inc1=20
>   Log:
>   In make buildenv, spell sh as ${SHELL}.  In this case, we don't want
>   to hard code /bin/sh since we're forking it for the user to type
>   commands into.  As such, ${SHELL} is the preferred thing users type
>   commands into.
>  =20
>   Revision  Changes    Path
>   1.524     +1 -1      src/Makefile.inc1
>=20
Please consider backing it out.  In this case, we want to hard code it
to "sh" since the stock ~root/.cshrc always resets $PATH, which breaks
"make buildenv" for root (which most of us use).  Testcase: "which cc"
=66rom under "make buildenv" shell.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--JbKQpFqZXJ2T76Sg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFDjzKdqRfpzJluFF4RAsHsAJ476stTNyzjBse9tq6sKN/yL7zRWQCcC5GL
rdKK8pRFB8KPlqv8o5/F/e8=
=/GCE
-----END PGP SIGNATURE-----

--JbKQpFqZXJ2T76Sg--