From owner-svn-src-all@FreeBSD.ORG Wed Jun 10 13:57:03 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D008106564A; Wed, 10 Jun 2009 13:57:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E9FE28FC08; Wed, 10 Jun 2009 13:57:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 99E8A46B45; Wed, 10 Jun 2009 09:57:02 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 7AFFA8A06E; Wed, 10 Jun 2009 09:57:01 -0400 (EDT) From: John Baldwin To: Bruce Simpson Date: Wed, 10 Jun 2009 09:54:19 -0400 User-Agent: KMail/1.9.7 References: <200905130255.n4D2tMQZ040010@svn.freebsd.org> <200906090946.46103.jhb@freebsd.org> <4A2F7159.3090800@incunabulum.net> In-Reply-To: <4A2F7159.3090800@incunabulum.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906100954.20026.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 10 Jun 2009 09:57:01 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-stable-7@freebsd.org, svn-src-stable@freebsd.org, Alexander Motin , src-committers@freebsd.org, Bruce Simpson , svn-src-all@freebsd.org Subject: Re: svn commit: r192033 - stable/7/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 13:57:04 -0000 On Wednesday 10 June 2009 4:39:53 am Bruce Simpson wrote: > John Baldwin wrote: > > http://www.FreeBSD.org/~jhb/patches/ata_ali.patch > > Ok, I've uploaded the patch, I must have just sent it inline before. > > > > Thanks! > > I did a p4 integ on my p4 work branch, built a NanoBSD USB stick image > with this patch incorporated into the kernel, booted from it > successfully on the affected machine, and got this panic just after the > WITNESS warning. > > Had to transcribe by hand, no debugging symbols at the moment. > > Fatal trap 12: page fault while in kernel mode > cpuid = 0 apic id = 00 > fault virtual address = 0x0 > fault code = supervisor read, page not present > instruction pointer = 0x20:0x0 > stack pointer = 0x28:0xc4adbb68 > frame pointer = 0x28:0xc4adbb9c > code segment = base 0x0, limit 0xfffff, type 0x1b > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 4 (g_down) > [thread pid 4 tid 100008] > Stopped at 0: error reading from address 0 > > ata_begin_transaction+0x18a > ata_start+0x1db > ata_queue_request+0x4a0 > ad_strategy+0x28f > g_disk_start+0x16a > g_io_schedule_down+0x281 > g_down_procbody+0x8d > fork_exit+0xb8 > fork_trampoline+0x8 > > Looks like some sort of switch table, call %*edx, just after > ata_pio_write() in that function. I'll try to grab line number info on > next boot from NanoBSD build tree. On an i386 8.0 kernel built here it is this line: 139 if ((error = ch->dma.load(request, NULL, &dummy))) { which would seem to indicate dma.load is NULL somehow. My patch doesn't affect that part of the code at all. Are you using any modules or is ata compiled into your kernel? Given that the resource stuff worked and that it worked on 7, I think I will commit it for now (and start the MFC timer) and assume this is a separate bug. -- John Baldwin