From owner-cvs-etc  Thu Sep 25 19:01:48 1997
Return-Path: <owner-cvs-etc>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id TAA29015
          for cvs-etc-outgoing; Thu, 25 Sep 1997 19:01:48 -0700 (PDT)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id TAA28994;
          Thu, 25 Sep 1997 19:01:31 -0700 (PDT)
Received: from gate.lan.awfulhak.org (localhost [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id BAA07189;
	Fri, 26 Sep 1997 01:40:49 +0100 (BST)
Message-Id: <199709260040.BAA07189@awfulhak.demon.co.uk>
X-Mailer: exmh version 2.0zeta 7/24/97
To: Mike Smith <mike@smith.net.au>
cc: Brian Somers <brian@awfulhak.org>,
        "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>,
        brian@freebsd.org (Brian Somers), cvs-committers@freebsd.org,
        cvs-all@freebsd.org, cvs-etc@freebsd.org
Subject: Re: cvs commit: src/etc/ppp ppp.linkup.sample 
In-reply-to: Your message of "Fri, 26 Sep 1997 00:51:18 +0930."
             <199709251521.AAA04380@word.smith.net.au> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 26 Sep 1997 01:40:48 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-etc@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> > > Yet another reason ppp has no business doing routing.  This leaves
> > > a window of time that no default route exists and if a connection
> > > happens to send a keepalive packet during it the conneciton is going
> > > to get torn down :-(.
> > > 
> > > Correct thing to do is a ``if route 0 exists, then route change 0 0,
> > > else route add 0 0''.
> > 
> > I'll be happy to add your patches to the source and documentation that
> > implement this wonderful syntax.
> 
> The right way to do this is probably for "add <anything>" to look and 
> remove any routes for <anything> before inserting the new one.
> 
> I would hope this was as easy as it sounds. 8)

Or (as I suspect was meant), a RTM_CHANGE is attempted before an 
RTM_ADD, and the RTM_ADD is only done if the CHANGE fails.  That way, 
altering the default won't leave a missing default for a bit.

I'll modify ppp so that it tries the RTM_CHANGE - makes sense.

> mike
> 
> 

-- 
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
      <http://www.Awfulhak.org>
Don't _EVER_ lose your sense of humour....