From owner-cvs-src@FreeBSD.ORG  Tue May 11 12:23:22 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 408DB16A4D0
	for <cvs-src@FreeBSD.org>; Tue, 11 May 2004 12:23:22 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3C73643D45
	for <cvs-src@FreeBSD.org>; Tue, 11 May 2004 12:23:21 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 76764 invoked by uid 1000); 11 May 2004 19:23:22 -0000
Date: Tue, 11 May 2004 12:23:22 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
In-Reply-To: <6.1.0.6.1.20040511194832.03e5e988@popserver.sfu.ca>
Message-ID: <20040511122030.I76738@root.org>
References: <20040510115040.0C9B516A53A@hub.freebsd.org>
	<20040511100208.C75906@root.org>
	<6.1.0.6.1.20040511194832.03e5e988@popserver.sfu.ca>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/led led.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 May 2004 19:23:22 -0000

On Tue, 11 May 2004, Colin Percival wrote:
> At 19:15 11/05/2004, David O'Brien wrote:
> >On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote:
> >> Do we even want __FBSDID in .h files?  It doesn't seem to make sense since
> >> it's not a compilation unit (i.e. no linkage).
> >
> >It actually does make sense, as a header's contents does wind up in a .o
> >eventually :-)  And header contents can be the cause of problems as much
> >as a .c file.  There is no problem having multiple __FBSDID in either
> >a.out or ELF objects.
>
> However, there are problems with having a header file's __FBSDID tags end
> up in a several binaries.  Quite apart from the resulting bloat, most changes
> to header files don't actually result in many binaries being modified;
> including compilable $Id$ tags in the headers would result in lots of
> spurious binary changes.  This would make me (and anyone who uses FreeBSD
> Update) very unhappy.

I agree.  This creates the same problems as panic() now changing object
files every time a comment is moved or other non-functional change.

-Nate