From owner-cvs-all@FreeBSD.ORG Thu Feb 19 09:32:31 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 341B716A55C; Thu, 19 Feb 2004 09:32:31 -0800 (PST) Received: from www.russia.cz (web.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D4CB43D2D; Thu, 19 Feb 2004 09:32:30 -0800 (PST) (envelope-from sobomax@portaone.com) Received: from portaone.com (localhost [127.0.0.1]) (authenticated bits=0) by www.russia.cz (8.12.8p2/8.12.8) with ESMTP id i1JHWOVt023450; Thu, 19 Feb 2004 18:32:25 +0100 (CET) (envelope-from sobomax@portaone.com) Message-ID: <4034F323.6050000@portaone.com> Date: Thu, 19 Feb 2004 19:32:19 +0200 From: Maxim Sobolev User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) X-Accept-Language: en-us, en, ru, uk MIME-Version: 1.0 To: Maxim Sobolev References: <200402191225.i1JCPhHd040004@repoman.freebsd.org> <20040219123140.GA12482@xor.obsecurity.org> <4034AD58.1040806@portaone.com> In-Reply-To: <4034AD58.1040806@portaone.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-ports@FreeBSD.ORG cc: ports-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Kris Kennaway Subject: Re: cvs commit: ports/net/asterisk Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2004 17:32:31 -0000 Maxim Sobolev wrote: > Kris Kennaway wrote: > >> On Thu, Feb 19, 2004 at 04:25:43AM -0800, Maxim Sobolev wrote: >> >>> sobomax 2004/02/19 04:25:42 PST >>> >>> FreeBSD ports repository >>> >>> Modified files: >>> net/asterisk Makefile Log: >>> Revert previous delta, according to Porter's Handbook: >>> >>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-wrkdirprefix.html >>> >>> >>> "In particular, if you are referring to a WRKDIR of another port, >>> note that >>> the correct location is ${WRKDIRPREFIX}${PORTSDIR}/subdir/name/work" >>> >>> Other ports that use ${.CURDIR} when reffering WRKDIR of another >>> port should >>> be fixed along with bento scripts. >> >> >> >> Maxim, please take a deep breath and don't try and pick a fight here. >> I'm quite happy to leave your port broken on bento if that's what you >> want (too bad for any users who might have wanted to install the >> package), but this commit isn't going to achieve anything else. > > > No, please fix bento scripts so that they adhere to documented > behaviour. We should not make behaviour workaround bento's bugs and > false assumptions! OK, after thinking its over, I've found a possible solution, which would allow to use documented ${WRKDIRPREFIX}${PORTSDIR} with /usr/ports symlinked to some other place, and will allow ports that reffer to WRKDIR of another port to be built outside of ${PORTSDIR}. It is simple as: Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.484 diff -d -u -r1.484 bsd.port.mk --- bsd.port.mk 4 Feb 2004 04:27:04 -0000 1.484 +++ bsd.port.mk 19 Feb 2004 17:25:44 -0000 @@ -1087,6 +1087,7 @@ # tree we are and thus can't go relative. They can, of course, be overridden # by individual Makefiles or local system make configuration. PORTSDIR?= /usr/ports +PORTSDIR!= ${REALPATH} ${PORTSDIR} LOCALBASE?= ${DESTDIR}/usr/local X11BASE?= ${DESTDIR}/usr/X11R6 LINUXBASE?= ${DESTDIR}/compat/linux I've tested it with symlinked /usr/ports and it appears to work just fine. Any objections to put it for testing on bento? -Maxim