From owner-svn-src-all@freebsd.org Sun Jan 15 19:57:04 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A37B9CB1DAA for ; Sun, 15 Jan 2017 19:57:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3202C1E13 for ; Sun, 15 Jan 2017 19:57:03 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: c8b03494-db5c-11e6-9357-bffcd86bd944 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id c8b03494-db5c-11e6-9357-bffcd86bd944; Sun, 15 Jan 2017 19:57:04 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v0FJusio012884; Sun, 15 Jan 2017 12:56:54 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1484510213.86335.110.camel@freebsd.org> Subject: Re: svn commit: r312236 - head/sys/net80211 From: Ian Lepore To: Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 15 Jan 2017 12:56:53 -0700 In-Reply-To: <201701151949.v0FJnl2h027169@repo.freebsd.org> References: <201701151949.v0FJnl2h027169@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2017 19:57:04 -0000 On Sun, 2017-01-15 at 19:49 +0000, Adrian Chadd wrote: > Author: adrian > Date: Sun Jan 15 19:49:47 2017 > New Revision: 312236 > URL: https://svnweb.freebsd.org/changeset/base/312236 > > Log: >   [net80211] add some more "is this XXX" macros for CTRL and DATA. >    >   There's already a macro for MGT. > > Modified: >   head/sys/net80211/ieee80211.h > > Modified: head/sys/net80211/ieee80211.h > ===================================================================== > ========= > --- head/sys/net80211/ieee80211.h Sun Jan 15 18:00:45 2017 > (r312235) > +++ head/sys/net80211/ieee80211.h Sun Jan 15 19:49:47 2017 > (r312236) > @@ -165,6 +165,12 @@ struct ieee80211_qosframe_addr4 { >  #define IEEE80211_IS_MGMT(wh) > \ >   (!! (((wh)->i_fc[0] & IEEE80211_FC0_TYPE_MASK) > \ >       == IEEE80211_FC0_TYPE_MGT)) > +#define IEEE80211_IS_CTL(wh) > \ > + (!! (((wh)->i_fc[0] & IEEE80211_FC0_TYPE_MASK) > \ > +     == IEEE80211_FC0_TYPE_CTL)) > +#define IEEE80211_IS_DATA(wh) > \ > + (!! (((wh)->i_fc[0] & IEEE80211_FC0_TYPE_MASK) > \ > +     == IEEE80211_FC0_TYPE_DATA)) >   >  #define IEEE80211_FC0_QOSDATA \ >   (IEEE80211_FC0_TYPE_DATA|IEEE80211_FC0_SUBTYPE_QOS|IEEE80211 > _FC0_VERSION_0) > What is the point of the !! in these macros?  The expressions already have boolean type (even in C++ where it matters) due to the ==.  Removing the !! would also make one level of parens redundant. -- Ian