From owner-svn-src-head@freebsd.org Sat Aug 4 23:01:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 594441056C0A for ; Sat, 4 Aug 2018 23:01:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCB138D349 for ; Sat, 4 Aug 2018 23:01:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id l14-v6so8015423iob.7 for ; Sat, 04 Aug 2018 16:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sIRVDCI304lqLYuccWityKgBCfuN2ZGWwGDtSkaWUr8=; b=iq14CLNr0q3kRSo+MuHNj9jkFxfY8b3GUZH7m+apMtRK9JMdddgpGxAX9zG+y7nzf0 OIuooKcY/HwjSB2OvZdXSiLqrzCoyP29mPykJwWpQTR6l4Ts5esMrw4djobHCxdvGNkJ /8Oco+kg+dYs/dc36LF5odg1JijxESvcVa/ovp6zUUDLpQ6XclDfRyXo58gjyveus4zB cx9xerwKlWbvERukVkgJUyhAwiP0XmJVnstw4MLt5zC1SCUVPhKW27rCjlVf495ITfFm MJ4h4Pm4tuk26EvPOsVRuvx05kR5K86zeKSbeePVVVyx5kAghyRMy4U6A9EpbGQiasxM KwUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sIRVDCI304lqLYuccWityKgBCfuN2ZGWwGDtSkaWUr8=; b=gciyxK0OBj/BZ/RPG1dmkHEs/vL/qZkMn8xd/gpXabmhWbA6HxF9fBZnEWM/LMo04h g6sBHxs0DHexARHB48dRZo6FinT28s3OQly7VfTgQliAw6oCGXU6SQmrjE1cdRqdjLxC NTnV4dsphBU/rDUE/QTq/DB7gGQpZu8rBGCVPrCWH3U7WngVqwUjRpJnB2xjAK3kuDmp aGvue+E+HMst/i4HtjgectGFOsGwNYUJTO/w05xxMAz5+biYF8tFtQiuffXvMqPHUChq 5CP9SVYnckCsnyOgVo3fKmaHLEemP3HQRQ8TEIc56/3zDkBtlgq2/IGKFWXokafcUDcL OZog== X-Gm-Message-State: AOUpUlGlXLxpm5EkDNeNKIHpJ5N+SvL9IMUt2pEOifhoT8JaUiOjzp7C l3hOho3NdLY2NdsMnyY/AkIfNj+vUQTIxUc/K7VfyKf0qh8= X-Google-Smtp-Source: AA+uWPx7tvzIxAQbfixm/sTeOX6eopD5J5narh5uEiqDGKYNCL3U2lqCN9TTpmvBvEql9LQLy1O6bmFauLaxxLUg/Sg= X-Received: by 2002:a6b:d004:: with SMTP id x4-v6mr10310673ioa.299.1533423688239; Sat, 04 Aug 2018 16:01:28 -0700 (PDT) MIME-Version: 1.0 References: <201808042208.w74M8OmD057603@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sun, 5 Aug 2018 00:01:15 +0100 Message-ID: Subject: Re: svn commit: r337334 - head/lib/libc/sys To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 23:01:29 -0000 On Sat, Aug 4, 2018, 11:48 PM Conrad Meyer wrote: > If not stale, it was inaccurate as-is. It seems to be used by a bunch > of different clock-related drivers and routines, e.g., > > $ rg '(tz_minuteswest|tz_dst|utc_offset)' | wc -l > 36 > Right. Nothings sets it any more though and hasn't in 30 years. Adjkerntz is what is used today. The other code was left for still lingering legacy uses in the early 1990s... To me there is a disconnect between that use and "timezone is no > longer used; this information is kept outside the kernel." > Right. It's not used nor set. It was the 4.2 BSD interface... If you or someone else wants to reword the "unused" note in a more > nuanced fashion, I'm definitely supportive of that. (Or remove the > kernel uses aside from pass-thru for gettimeofday and restore the > original note, of course.) > I'll do it. I was actually going to deorbit the date(1) -t/-d options on the basis > of the settimeofday manual page note until I did the due diligence to > verify it was actually unused, and discovered that not to be true. > We should do that. This code has not been relevant in decades. Warner All the best, > Conrad > > > > On Sat, Aug 4, 2018 at 3:15 PM, Warner Losh wrote: > > How is this stale? It said it unused, and now it doesn't say this are is > > completely ignored. > > > > Warner > > > > On Sat, Aug 4, 2018, 11:08 PM Conrad Meyer wrote: > >> > >> Author: cem > >> Date: Sat Aug 4 22:08:24 2018 > >> New Revision: 337334 > >> URL: https://svnweb.freebsd.org/changeset/base/337334 > >> > >> Log: > >> settimeofday(2): Remove stale note about timezone > >> > >> Contrary to the removed comment, the kernel does appear to use the > >> timezone > >> argument of settimeofday. The comment dates to the BSD4.4 import; I > >> assume it > >> is just stale. > >> > >> Modified: > >> head/lib/libc/sys/gettimeofday.2 > >> > >> Modified: head/lib/libc/sys/gettimeofday.2 > >> > >> > ============================================================================== > >> --- head/lib/libc/sys/gettimeofday.2 Sat Aug 4 21:57:17 2018 > >> (r337333) > >> +++ head/lib/libc/sys/gettimeofday.2 Sat Aug 4 22:08:24 2018 > >> (r337334) > >> @@ -28,7 +28,7 @@ > >> .\" @(#)gettimeofday.2 8.2 (Berkeley) 5/26/95 > >> .\" $FreeBSD$ > >> .\" > >> -.Dd December 27, 2015 > >> +.Dd August 4, 2018 > >> .Dt GETTIMEOFDAY 2 > >> .Os > >> .Sh NAME > >> @@ -44,11 +44,6 @@ > >> .Ft int > >> .Fn settimeofday "const struct timeval *tp" "const struct timezone > *tzp" > >> .Sh DESCRIPTION > >> -.Bf -symbolic > >> -Note: timezone is no longer used; this information is kept outside > >> -the kernel. > >> -.Ef > >> -.Pp > >> The system's notion of the current Greenwich time and the current time > >> zone is obtained with the > >> .Fn gettimeofday > >> > > >