From nobody Sun May 17 19:44:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gJWc70P17z6ctyF for ; Sun, 17 May 2026 19:44:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gJWc65LrLz3L30 for ; Sun, 17 May 2026 19:44:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779047094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gI+0l6tqk+HdCCTSIQYEhQUBJuTa7uDgHquZV313aWM=; b=A61eT6hJnao9AhhZEwmJCYbBF3rjXJHc4Rj13IRXk8Ubgy8FU947nupy1RW6Zgbi2qq/xX lQI53+mZCwk89GHqRHo9JeP8zs00H03S89RaipBWgiA7FpxLASn7qRKtrHmJpyK8wgWXTW sxytpRuL9oqg8HNIQgGgJss5LADTeCHdqx6bCeCyx5Lr3gb7heuidh8uo47bvunURtuvx4 W3DDkxDSrhwzcd3W8KI43mf/3+l4zE4BEpfSbNKyerZZRdeAUBuSiGIKIpHbD/JlpBMyRr g0dGpXFsOtNI7Ff0WXjeGRb9uloNSHzMqd864GRUiomMSxDrpKgfnoK17OgWQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779047094; a=rsa-sha256; cv=none; b=r2iz24b9UBZQQ1U/QDIDHLXX38AQZ1Fwc6mbvK8Hs3DbzOpMWK39UPs5JKzfTycHSZW7c4 DP1fLcDGoJA1LzhLWfovn0vir2W/QMat9g+soq+u/no1qLNIYdN4384J9eh26xXjDGK06D PDV+xBuPjENVyMxXCw0/VYSPOkKkkVTz1yKI61xBZ/vrewvTGEIU1IA0C/+a0Z1QssJL1w MZEvmRAzmQE96CeqX95zGXHMTdoYyxOONX4oDD3ASq+xxXwCVtyy0rsaEQaz5H25yJj7E3 IFwMEhbFH0SkVUwH8zhZ/dUByA5WqR8/2bBYCsYyC294vS7B445xUaAPP3rlJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779047094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gI+0l6tqk+HdCCTSIQYEhQUBJuTa7uDgHquZV313aWM=; b=nnAwCF6jNDqvMe5QuvNFcFvVWgte+qEXFYcvws3LY9J1DT1pPQ7neLiw3IWK4bkd5QPJIB x4380io69qT459PIXWhTPiCNZ7sP6zoIqY6Eo16yGY7x0hWyNUM1j51IBSsN3tV4iXVMhB eBHCwLywBKkCTrB2tNqNBmJHXTM7966towYK2I7I3GZYKAqRRKtWFr7di7+t4ig1L1mkD+ wFdEKvt9A2mKrJHzqqHhLLaTTMhaoj2QF8nvBmFzbYgesC3VZVmd7jxaxVjVjY722i6SnI jaO9IHdbvwLBKoYH+RnF38vWQc58vtJxEQsHrpVkcEtVpDOPQQHc7OPSFejk1A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gJWc64fV2zvQN for ; Sun, 17 May 2026 19:44:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 366ed by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 17 May 2026 19:44:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 7bdf2b5d5fba - main - nullfs: do not allow to mount a vnode over itself List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 Auto-Submitted: auto-generated Date: Sun, 17 May 2026 19:44:49 +0000 Message-Id: <6a0a1ab1.366ed.93367f9@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 commit 7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 Author: Konstantin Belousov AuthorDate: 2026-05-16 22:16:45 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-17 19:44:06 +0000 nullfs: do not allow to mount a vnode over itself This causes recursion in VFS that is not worth handling. PR: 275570 Reported by: Alex S Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57043 --- sys/fs/nullfs/null_vfsops.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c index c3eec727aeea..0ec4f9c87297 100644 --- a/sys/fs/nullfs/null_vfsops.c +++ b/sys/fs/nullfs/null_vfsops.c @@ -151,6 +151,14 @@ nullfs_mount(struct mount *mp) */ lowerrootvp = ndp->ni_vp; + /* + * Do not allow to mount a vnode over itself. + */ + if (mp->mnt_vnodecovered == lowerrootvp) { + vput(lowerrootvp); + return (EDEADLK); + } + /* * Check multi null mount to avoid `lock against myself' panic. */