From owner-freebsd-current@freebsd.org Tue Oct 9 20:54:20 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4FB710BC8C1 for ; Tue, 9 Oct 2018 20:54:19 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.protected-networks.net (mail.protected-networks.net [IPv6:2001:470:8d59:1::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protected-networks.net", Issuer "Protected Networks CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 73F637CCF0; Tue, 9 Oct 2018 20:54:19 +0000 (UTC) (envelope-from imb@protected-networks.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= protected-networks.net; h=content-transfer-encoding :content-language:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:subject:subject; s=201508; t=1539118456; bh=eEGL+lNL u6dr+gyfD11oJH2gZugWG9tlRow96K7bN2g=; b=XuHNanb/IMuMLk1qcchuj2J8 EFSf3G3InYb0uqDD0hwYOG1q30cHA6FUNUIXyBY3szFDGBm/znQOHv3VP76B8HND xF8I8HxAwvuTvZfASaLxUPGCwOTBnDjmAU/kiFCoyAS3k0NMGYxb9jIo6EEsl/mG Pxy1bakGNTeKcyA+kTg= Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: imb@mail.protected-networks.net) by mail.protected-networks.net (Postfix) with ESMTPSA id 28CFFBAB0; Tue, 9 Oct 2018 16:54:16 -0400 (EDT) Subject: Re: SVN r339216 breaks ssh to i386 devices To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= Cc: Marek Zarychta , emaste@freebsd.org, FreeBSD Current References: <6bd10ee9-eb03-1f9f-c533-fdb5d02eb829@protected-networks.net> <20181008190846.GA84941@plan-b.pwste.edu.pl> <86tvlwcee0.fsf@next.des.no> <86lg78c92o.fsf@next.des.no> <1e8f80dd-d7c9-e82c-987f-f84c4103a039@plan-b.pwste.edu.pl> <375ebc04-82a3-6497-ad60-5afee1088f0a@protected-networks.net> <86bm839bf2.fsf@next.des.no> From: Michael Butler Openpgp: preference=signencrypt Message-ID: <6d067294-653b-a408-1ac6-471f64584e45@protected-networks.net> Date: Tue, 9 Oct 2018 16:54:15 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <86bm839bf2.fsf@next.des.no> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 20:54:20 -0000 On 10/9/18 3:18 PM, Dag-Erling Smørgrav wrote: > Michael Butler writes: >> Marek Zarychta writes: >>> I have connected serial console to affected box and upgraded system >>> from patched sources. I am sorry to say that this patch doesn't >>> solve the issue for 32-bit ARM (RPi2). Still sshd terminates session >>> with the error "fatal: mm_getpwnamallow: receive get struct passwd >>> failed [preauth]". >> My experience is similar - there maybe another 32/64-bit issue :-( > > Correct, there is a size_t being passed as as an u64 as well. That > explains why arm32 was broken too, and not just i386. The quick fix is > to replace size_t with u_int64_t in sshbuf_get_passwd(), on line 513 of > sshbuf-getput-basic.c (with my previous patch applied). I have a full > patch in the pipeline. I can confirm that SVN r339263 solves this for me - thanks! imb