From owner-dev-commits-src-branches@freebsd.org Wed Dec 30 00:38:21 2020 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15CA54CFBAE; Wed, 30 Dec 2020 00:38:21 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5C7c73kZz3sSK; Wed, 30 Dec 2020 00:38:20 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qk1-f170.google.com with SMTP id f26so12898689qka.0; Tue, 29 Dec 2020 16:38:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r13nv4a05Q2iJbQkkcE3kjogHS5DVaTt5ul/RV1ChMI=; b=dUGV/v246Vl+QdwCH2MJ44Gj4/mcFN5lbKG2VjSu2ZbgXDZeVtGVwFYylFN2UOh5zV GcvRvIkjJVVaijaINgXrxLG8gyAFQ2G0WSLtVYITfo6BeHRcW8lPD6QP9gX0tZkULawf Ct9zYTwnKW8fYxu5xwwUtcuZF8OklIaw0JQxOOgSiCbfCvGypkSq4mPheOUhswa+/YRC TGUD2uz+3xR2y33lC7oVLoBzl7i2zWn89iaCArlbxggX7aNOyRj6Kk1zCdMhNW1b4WAR U+XNlxnJokM2GfmJxHsk0Np4CH3COQxxz4kG0dHzgLgZgsRccx7knCHlU27QPqMxk2qv d1gA== X-Gm-Message-State: AOAM5306d+VP6YGaMBlOh9tASaMQf5XK8MyL7hUUSJY2TjbCcyhQ63b9 Szdj21cQpw1FQZami3Uc5XK7eESwDBZbNQ== X-Google-Smtp-Source: ABdhPJxzcz2fHcqjl10TyseRi6/IanYe72JJIxkoqIJkj0UYc7QxcPAAFmr6YGdg/BM3UDXimbhKIQ== X-Received: by 2002:a37:63c3:: with SMTP id x186mr52708317qkb.361.1609288699799; Tue, 29 Dec 2020 16:38:19 -0800 (PST) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com. [209.85.222.179]) by smtp.gmail.com with ESMTPSA id c139sm25643196qke.24.2020.12.29.16.38.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 16:38:19 -0800 (PST) Received: by mail-qk1-f179.google.com with SMTP id z11so12842839qkj.7; Tue, 29 Dec 2020 16:38:19 -0800 (PST) X-Received: by 2002:a37:6189:: with SMTP id v131mr49752730qkb.337.1609288699044; Tue, 29 Dec 2020 16:38:19 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Tue, 29 Dec 2020 16:38:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D5C7c73kZz3sSK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the stable branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 00:38:21 -0000 On Tue, Dec 29, 2020 at 3:32 PM Kyle Evans wrote: > > Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. > Ah, thanks for the reminder. I'll take another look re in-tree gcc. Based on the other commits I've MFC'd, I'm pretty sure it's been broken for months anyway, but I'll see what I can do if the fixes are easy. > On Tue, Dec 29, 2020, 17:07 Ryan Libby wrote: >> >> The branch stable/12 has been updated by rlibby: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=269b7d8ac1e533a1f214904ab7bce50f5c14fe3e >> >> commit 269b7d8ac1e533a1f214904ab7bce50f5c14fe3e >> Author: Kyle Evans >> AuthorDate: 2020-03-05 22:45:16 +0000 >> Commit: Ryan Libby >> CommitDate: 2020-12-29 23:04:40 +0000 >> >> tftpd: tests: raise targeted cstd to c11 >> >> r358556 added alignas() use to the functional tests, which isn't defined >> until C11. Raise the -std to C11 to fix the build under freebsd-gcc{6,9}. >> >> Reported by: mhorne, Jenkins/CI >> >> (cherry picked from commit 924e10b809a9fcbc8688c1b5848f60b48e6103fe) >> --- >> libexec/tftpd/tests/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libexec/tftpd/tests/Makefile b/libexec/tftpd/tests/Makefile >> index 06c5537372a7..9aa420cec1a5 100644 >> --- a/libexec/tftpd/tests/Makefile >> +++ b/libexec/tftpd/tests/Makefile >> @@ -10,5 +10,6 @@ TEST_METADATA.functional+= timeout=15 >> >> LIBADD= util >> WARNS?= 6 >> +CSTD= c11 >> >> .include