From owner-freebsd-net@FreeBSD.ORG  Tue Apr  1 20:39:35 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A74E5106564A
	for <freebsd-net@freebsd.org>; Tue,  1 Apr 2008 20:39:35 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.freebsd.org (Postfix) with ESMTP id D26348FC1B
	for <freebsd-net@freebsd.org>; Tue,  1 Apr 2008 20:39:34 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: (qmail 44871 invoked from network); 1 Apr 2008 19:48:04 -0000
Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1])
	(envelope-sender <andre@freebsd.org>)
	by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
	for <rpaulo@fnop.net>; 1 Apr 2008 19:48:04 -0000
Message-ID: <47F29D91.6060408@freebsd.org>
Date: Tue, 01 Apr 2008 22:39:45 +0200
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Thunderbird 1.5.0.14 (Windows/20071210)
MIME-Version: 1.0
To: Rui Paulo <rpaulo@fnop.net>
References: <fstmm9$oci$1@ger.gmane.org> <20080401191246.GA1491@fnop.net>
	<fsu2c6$6iv$1@ger.gmane.org> <47F29471.10901@freebsd.org>
	<20080401202005.GB1491@fnop.net>
In-Reply-To: <20080401202005.GB1491@fnop.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org, rpaulo@freebsd.org,
	Mark Atkinson <atkin901@yahoo.com>
Subject: Re: panic: tcp_addoptions: TCP options too long w/
 with	TCP_SIGNATURE support
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2008 20:39:35 -0000

Rui Paulo wrote:
> On Tue, Apr 01, 2008 at 10:00:49PM +0200, Andre Oppermann wrote:
>> The order of the TCP options was changed recently to fix another problem.
>> This has caused sub-optimal padding and this overflow as not all options
>> fit.  The tcp_addoptions() loop is not bound internally.
>>
>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_output.c?rev=1.146
> 
> Hmm. Are you sure you wanted to show this revision ?
> There's not change for optlen because TCPOLEN_NOP == 1, I think.

Oops, wrong URL in paste buffer.  Try this:

  http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_var.h.diff?r1=1.160;r2=1.161

-- 
Andre