From owner-svn-src-head@FreeBSD.ORG  Sun May 27 20:30:31 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9BCD8106566B;
	Sun, 27 May 2012 20:30:31 +0000 (UTC)
	(envelope-from rdivacky@vlakno.cz)
Received: from vlakno.cz (lev.vlakno.cz [46.28.110.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 593FE8FC1A;
	Sun, 27 May 2012 20:30:30 +0000 (UTC)
Received: by vlakno.cz (Postfix, from userid 1002)
	id 5BC797F3ECA; Sun, 27 May 2012 22:31:00 +0200 (CEST)
Date: Sun, 27 May 2012 22:31:00 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20120527203100.GA22921@freebsd.org>
References: <201205270527.q4R5Rm44028055@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201205270527.q4R5Rm44028055@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2012 20:30:31 -0000

Fwiw, to enable the same thing in clang you want this simple patch:

===================================================================
--- Tools.cpp   (revision 157545)
+++ Tools.cpp   (working copy)
@@ -4794,6 +4794,7 @@
   if (Args.hasArg(options::OPT_static)) {
     CmdArgs.push_back("-Bstatic");
   } else {
+    CmdArgs.push_back("--hash-style=both");
     if (Args.hasArg(options::OPT_rdynamic))
       CmdArgs.push_back("-export-dynamic");
     CmdArgs.push_back("--eh-frame-hdr");



I cant commit this upstream as this option doesn't work with ld 2.15. What
should be done here? Commit this to local FreeBSD version? Commit it upstream
making it not work with old ld? Leave it out completely?

On Sun, May 27, 2012 at 05:27:48AM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sun May 27 05:27:47 2012
> New Revision: 236137
> URL: http://svn.freebsd.org/changeset/base/236137
> 
> Log:
>   Enable gnu hash generation for dynamic ELF binaries on x86.
>   
>   Reviewed by:	kan
> 
> Modified:
>   head/contrib/gcc/config/i386/freebsd.h
>   head/contrib/gcc/config/i386/freebsd64.h
> 
> Modified: head/contrib/gcc/config/i386/freebsd.h
> ==============================================================================
> --- head/contrib/gcc/config/i386/freebsd.h	Sun May 27 05:24:53 2012	(r236136)
> +++ head/contrib/gcc/config/i386/freebsd.h	Sun May 27 05:27:47 2012	(r236137)
> @@ -49,6 +49,7 @@ Boston, MA 02110-1301, USA.  */
>  	%{rdynamic: -export-dynamic} \
>  	%{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \
>        %{static:-Bstatic}} \
> +    %{!static:--hash-style=both} \
>      %{symbolic:-Bsymbolic}"
>  
>  /* Reset our STARTFILE_SPEC which was properly set in config/freebsd.h
> 
> Modified: head/contrib/gcc/config/i386/freebsd64.h
> ==============================================================================
> --- head/contrib/gcc/config/i386/freebsd64.h	Sun May 27 05:24:53 2012	(r236136)
> +++ head/contrib/gcc/config/i386/freebsd64.h	Sun May 27 05:27:47 2012	(r236137)
> @@ -54,4 +54,5 @@ Boston, MA 02110-1301, USA.  */
>          %{rdynamic:-export-dynamic} \
>  	%{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \
>      %{static:-Bstatic}} \
> +  %{!static:--hash-style=both} \
>    %{symbolic:-Bsymbolic}"