From owner-freebsd-bluetooth@FreeBSD.ORG  Fri Jul 29 12:58:01 2005
Return-Path: <owner-freebsd-bluetooth@FreeBSD.ORG>
X-Original-To: freebsd-bluetooth@freebsd.org
Delivered-To: freebsd-bluetooth@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E1A9816A41F
	for <freebsd-bluetooth@freebsd.org>;
	Fri, 29 Jul 2005 12:58:01 +0000 (GMT)
	(envelope-from urnenfel@tiscali.es)
Received: from smtp108.mail.sc5.yahoo.com (smtp108.mail.sc5.yahoo.com
	[66.163.170.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 9B06343D46
	for <freebsd-bluetooth@freebsd.org>;
	Fri, 29 Jul 2005 12:58:01 +0000 (GMT)
	(envelope-from urnenfel@tiscali.es)
Received: (qmail 69463 invoked from network); 29 Jul 2005 12:58:01 -0000
Received: from unknown (HELO @vodafone.es) (urnen81@84.173.155.9 with login)
	by smtp108.mail.sc5.yahoo.com with SMTP; 29 Jul 2005 12:58:00 -0000
Date: Fri, 29 Jul 2005 14:51:52 +0000
From: Oliver <urnenfel@tiscali.es>
In-Reply-To: <42E920D9.7050907@savvis.net>
Message-Id: <20050729145152.6600.1@@vodafone.es>
Mime-Version: 1.0
References: <20050728113713.2925.5@@vodafone.es>
	<42E90D5E.3030404@savvis.net> <20050728193757.15889.2@@vodafone.es>
	<42E920D9.7050907@savvis.net>
To: freebsd-bluetooth@freebsd.org
User-Agent: Beam yT Release
Content-Type: text/plain;
 charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Could check this?
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
	<freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2005 12:58:02 -0000

Hi,

In file ng_l2cap_llpi.c func ng_l2cap_lp_con_ind(...) 
concretely line:251:

	/* Create and send LP_ConnectRsp event */
	NG_MKMESSAGE(rsp, NGM_HCI_COOKIE, NGM_HCI_LP_CON_RSP,
		sizeof(*rp), M_NOWAIT);
	if (msg == NULL) {
		ng_l2cap_free_con(con);
		error = ENOMEM;
		goto out;
	}

NG_MKMESSAGE function creates a NG_MESSAGE called rsp? for being send with 
NG_SEND_MSG_HOOK afterwards, am I right?

if it is, shouldnt we be cheking the rsp pointer instead of msg ?
...the msg pointer is used much before in this func...so if it was NULL it 
should have crashed much before...

Am I missing something?

thanks,

		
______________________________________________ 
Renovamos el Correo Yahoo! 
Nuevos servicios, más seguridad 
http://correo.yahoo.es