From owner-svn-src-all@freebsd.org Fri Sep 13 11:59:58 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85111EF41B; Fri, 13 Sep 2019 11:59:58 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id 46VDhs3K58z4XlF; Fri, 13 Sep 2019 11:59:56 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.103] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id E0E81361306; Fri, 13 Sep 2019 21:59:53 +1000 (AEST) Date: Fri, 13 Sep 2019 21:59:51 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Cy Schubert cc: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio In-Reply-To: <201909011932.x81JWYts004074@slippy.cwsent.com> Message-ID: <20190913214846.P1215@besplex.bde.org> References: <201909011612.x81GC5DW097846@repo.freebsd.org> <201909011932.x81JWYts004074@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=ZsRUh5Ms3fib6wNPaIgA:9 a=CjuIK1q_8ugA:10 a=EVd9C9LBHkwA:10 a=IjZwj45LgO3ly-622nXo:22 X-Rspamd-Queue-Id: 46VDhs3K58z4XlF X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of brde@optusnet.com.au designates 211.29.132.249 as permitted sender) smtp.mailfrom=brde@optusnet.com.au X-Spamd-Result: default: False [0.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; RCVD_IN_DNSWL_LOW(-0.10)[249.132.29.211.list.dnswl.org : 127.0.5.1]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:211.29.132.0/23:c]; FREEMAIL_FROM(0.00)[optusnet.com.au]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[optusnet.com.au]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RBL_MAILSPIKE_WORST(2.00)[249.132.29.211.rep.mailspike.net : 127.0.0.10]; RCPT_COUNT_FIVE(0.00)[5]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(0.00)[ip: (-5.16), ipnet: 211.28.0.0/14(-3.26), asn: 4804(-2.40), country: AU(0.01)]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[optusnet.com.au]; ASN(0.00)[asn:4804, ipnet:211.28.0.0/14, country:AU]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 11:59:58 -0000 On Sun, 1 Sep 2019, Cy Schubert wrote: I'm replying to this reply since I lost the original mail. > In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes: >> Author: emaste >> Date: Sun Sep 1 16:12:05 2019 >> New Revision: 351659 >> URL: https://svnweb.freebsd.org/changeset/base/351659 >> >> Log: >> libc: remove gets >> >> gets is unsafe and shouldn't be used (for many years now). Leave it in >> the existing symbol version so anything that previously linked aginst it >> still runs, but do not allow new software to link against it. >> >> (The compatability/legacy implementation must not be static so that >> the symbol and in particular the compat sym gets@FBSD_1.0 make it >> into libc.) >> >> PR: 222796 (exp-run) >> Reported by: Paul Vixie >> Reviewed by: allanjude, cy, eadler, gnn, jhb, kib, ngie (some earlie >> r) >> Relnotes: Yes >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D12298 This breaks for most old standards, and bogotitifies the ifdefs that attempt to support old standards. used to be more careful with these ifdefs than most system headers. C11 removed gets(), but POSIX.1-2017 (Issue 7) still has it (marked as obsolescent). Thus this change breaks support for all versions of POSIX. Bruce