From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Jul  4 07:08:20 2003
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 799DA37B401
	for <freebsd-ports-bugs@FreeBSD.org>;
	Fri,  4 Jul 2003 07:08:20 -0700 (PDT)
Received: from worf.kerna.com (worf.kerna.com [194.106.143.118])
	by mx1.FreeBSD.org (Postfix) with SMTP id 495DE43FE1
	for <freebsd-ports-bugs@FreeBSD.org>;
	Fri,  4 Jul 2003 07:08:19 -0700 (PDT)	(envelope-from james@now.ie)
Received: (qmail 34220 invoked by uid 1001); 4 Jul 2003 14:08:24 -0000
Date: Fri, 4 Jul 2003 15:08:24 +0100
From: James Raftery <james@now.ie>
To: freebsd-ports-bugs@FreeBSD.org, osa@FreeBSD.org
Message-ID: <20030704140824.GA34202@bender.kerna.ie>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
cc: albert.kinderman@csun.edu
cc: peter@dataloss.nl
Subject: Re: ports/54017: vnc ports misses XFree86-client dep
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jul 2003 14:08:20 -0000

Thanks Albert, Peter and Sergey,

Patch below to:

	o Add RUN_DEPEND on XFree86-4-clients, for the xauth binary, if
	  installing server components. Reported by Albert Kinderman
	  <albert.kinderman@csun.edu> and Peter van Dijk
	  <peter@dataloss.nl>

	o Add RUN_DEPEND on XFree86-4-fontDefaultBitmaps, for a 'fixed'
	  font, if installing server components. Reported by Albert
	  Kinderman <albert.kinderman@csun.edu> and Peter van Dijk
	  <peter@dataloss.nl>

	o Print a short message in pre-build to note the WITHOUT_SERVER
	  knob.

	o Bump PORTREVISION


Thanks,
james


diff -ruN vnc.orig/Makefile vnc/Makefile
--- vnc.orig/Makefile	Sun Mar 23 07:10:22 2003
+++ vnc/Makefile	Thu Jun 19 17:28:11 2003
@@ -7,6 +7,7 @@
 
 PORTNAME=	vnc
 PORTVERSION=	3.3.7
+PORTREVISION=	1
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.realvnc.com/dist/
 DISTNAME=	${PORTNAME}-${PORTVERSION}-unixsrc
@@ -31,7 +32,18 @@
 MAN1+=		Xvnc.1 \
 		vncserver.1
 
+RUN_DEPENDS+=	xauth:${PORTSDIR}/x11/XFree86-4-clients \
+		${X11BASE}/lib/X11/fonts/misc/6x13-ISO8859-1.pcf.gz:${PORTSDIR}/x11-fonts/XFree86-4-fontDefaultBitmaps
+
 USE_PERL5_RUN=	yes
+.endif
+
+pre-build:
+.if !defined(WITHOUT_SERVER)
+	@${ECHO_MSG} "NOTE:"
+	@${ECHO_MSG} "   Use 'make -DWITHOUT_SERVER ...' if you do not wish to"
+	@${ECHO_MSG} "   compile/install the VNC server components."
+	@${ECHO_MSG} ""
 .endif
 
 post-build: