From owner-svn-src-all@FreeBSD.ORG Sat Mar 13 19:54:17 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F2B81065670; Sat, 13 Mar 2010 19:54:17 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id 0912F8FC2C; Sat, 13 Mar 2010 19:54:16 +0000 (UTC) Received: from [10.10.1.82] (s224.GtokyoFL6.vectant.ne.jp [222.228.90.224]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o2DJsCpS073694 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 13 Mar 2010 14:54:14 -0500 (EST) (envelope-from rrs@lakerest.net) Message-Id: <17A93DA8-4022-4AA6-B1B2-28CD3E7719C2@lakerest.net> From: Randall Stewart To: Bruce Simpson In-Reply-To: <4B9B99A9.7040904@incunabulum.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Sun, 14 Mar 2010 04:54:11 +0900 References: <201003122258.o2CMwqDM039077@svn.freebsd.org> <2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net> <92C0A9B0-9297-4F56-A6A1-603006423230@FreeBSD.org> <4B9B99A9.7040904@incunabulum.net> X-Mailer: Apple Mail (2.936) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "Robert N. M. Watson" Subject: Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 19:54:17 -0000 Hmm... M_PROTO* good idea ;-) On Mar 13, 2010, at 10:56 PM, Bruce Simpson wrote: > On 03/13/10 13:53, Robert N. M. Watson wrote: >> On Mar 13, 2010, at 1:50 PM, Randall Stewart wrote: >> >>> I could refactor that this way if you want... it would mean a few >>> more de-ref's and >>> looking to see if its a v4 or v6 packet and then doing the proper >>> offset... >>> > > This is the sort of thing which M_PROTO* flags are good for. > > Derefs in the hot path should be amortized whenever that makes sense. > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)