Date: Sun, 14 Mar 2010 04:54:11 +0900 From: Randall Stewart <rrs@lakerest.net> To: Bruce Simpson <bms@incunabulum.net> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "Robert N. M. Watson" <rwatson@FreeBSD.org> Subject: Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6 Message-ID: <17A93DA8-4022-4AA6-B1B2-28CD3E7719C2@lakerest.net> In-Reply-To: <4B9B99A9.7040904@incunabulum.net> References: <201003122258.o2CMwqDM039077@svn.freebsd.org> <alpine.BSF.2.00.1003131257060.51476@fledge.watson.org> <2F4A2F84-4955-49C2-B25E-BB987BC27815@lakerest.net> <92C0A9B0-9297-4F56-A6A1-603006423230@FreeBSD.org> <4B9B99A9.7040904@incunabulum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hmm... M_PROTO* good idea ;-) On Mar 13, 2010, at 10:56 PM, Bruce Simpson wrote: > On 03/13/10 13:53, Robert N. M. Watson wrote: >> On Mar 13, 2010, at 1:50 PM, Randall Stewart wrote: >> >>> I could refactor that this way if you want... it would mean a few >>> more de-ref's and >>> looking to see if its a v4 or v6 packet and then doing the proper >>> offset... >>> > > This is the sort of thing which M_PROTO* flags are good for. > > Derefs in the hot path should be amortized whenever that makes sense. > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17A93DA8-4022-4AA6-B1B2-28CD3E7719C2>