Date: Sun, 16 Oct 2016 15:20:12 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 90815] [smbfs] [patch] SMBFS with character conversions sometimes hangs Message-ID: <bug-90815-3630-b5NMu1cn7I@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-90815-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-90815-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D90815 --- Comment #6 from Tomoaki AOKI <junchoon@dec.sakura.ne.jp> --- (In reply to Andrey V. Elsukov from comment #5) With my patch, if smb_copy_iconv() is called recursively, you're right. If not, my patch can be better, as whole src is kept unchanged if iconv_con= v() returns -1. *According to the prototype of iconv_conv() in src/sys/sys/iconv.h, src is constant, so shouldn't be changed at all by iconv_conv(). With my patch, if modified code path is executed, cp would copy with origin= al filename unchanged and succeeds, while with yours the file is skipped. Anyway, your patch would be safer and cp didn't hang for me, at least for n= ow, while my patch can be more convenient if iconv implementation is problematic and the src string should be safe for dst. Will need another eye to proceed. By the way, your patch couldn't be applied (incomplete and need fix). Sorry for delay. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-90815-3630-b5NMu1cn7I>