From owner-svn-src-all@freebsd.org Fri Jul 10 03:08:52 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA1BF995742; Fri, 10 Jul 2015 03:08:52 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-yk0-x229.google.com (mail-yk0-x229.google.com [IPv6:2607:f8b0:4002:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78845E72; Fri, 10 Jul 2015 03:08:52 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by ykey15 with SMTP id y15so56604144yke.3; Thu, 09 Jul 2015 20:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tdXGd8pL/BOZg2h1tV4beI0xFfYL4oJ1rpPzaHLxMck=; b=JopqpsVoKo+lZ6hIVUgdtXARZKSxebgZx+z8XOabpGNbeSwfEN95OuXK/Fgw6VzMRR 7VRY0HyNbzYOJyooXxF+7HO7ZOA9NMItMPdmtgORQK0sIRAmjWVxqKiQpt1XkBFtIfc8 wSVHgaKKAemhTzjQcRaXya9uliR9+UsUikSAx9wf1YodkvrTFCSRtT60sVaWcC6uoN+k dHgn8Hy67ZsKbdi7lWrHy83MiAjug9VChEMAF0BUBbtPZw8wtQPVKrpHM7WfLviJIgDN geIhxdR9K9NLl6icYKAuCXNgeQux1yWxkQTfSscvuyc+pvM3R4ziHKYEVW0RzYNIChW0 ySaw== MIME-Version: 1.0 X-Received: by 10.170.206.139 with SMTP id x133mr21174791yke.126.1436497731554; Thu, 09 Jul 2015 20:08:51 -0700 (PDT) Sender: pkelsey@gmail.com Received: by 10.129.138.68 with HTTP; Thu, 9 Jul 2015 20:08:51 -0700 (PDT) In-Reply-To: References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org> Date: Thu, 9 Jul 2015 23:08:51 -0400 X-Google-Sender-Auth: HiEUXcpSONEdwAPUCoitV263_aU Message-ID: Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto From: Patrick Kelsey To: Warner Losh Cc: George Neville-Neil , Peter Wemm , svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 03:08:52 -0000 On Thu, Jul 9, 2015 at 10:45 PM, Warner Losh wrote: > > > On Jul 9, 2015, at 8:27 PM, George Neville-Neil wrote: > > > > > > > > On 9 Jul 2015, at 18:26, Peter Wemm wrote: > > > >> On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: > >>> Author: gnn > >>> Date: Thu Jul 9 18:16:35 2015 > >>> New Revision: 285336 > >>> URL: https://svnweb.freebsd.org/changeset/base/285336 > >>> > >>> Log: > >>> Add support for AES modes to IPSec. These modes work both in software > >>> only mode and with hardware support on systems that have AESNI > >>> instructions. > >>> > >>> Differential Revision: D2936 > >>> Reviewed by: jmg, eri, cognet > >>> Sponsored by: Rubicon Communications (Netgate) > >>> > >>> Modified: > >>> head/sys/netipsec/xform_ah.c > >>> head/sys/netipsec/xform_esp.c > >> > >>> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) > >>> case CRYPTO_SHA2_512_HMAC: > >>> alen = esph->hashsize/2; > >>> break; > >>> + case CRYPTO_AES_128_GMAC: > >>> + case CRYPTO_AES_192_GMAC: > >>> + case CRYPTO_AES_256_GMAC: > >>> + alen = esph->hashsize; > >>> + break; > >>> default: > >>> alen = AH_HMAC_HASHLEN; > >>> break; > >> > >> This introduces a LINT compile failure: > >> > >> /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_128_GMAC' > >> case CRYPTO_AES_128_GMAC: > >> ^ > >> /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_192_GMAC' > >> case CRYPTO_AES_192_GMAC: > >> ^ > >> /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared > identifier > >> 'CRYPTO_AES_256_GMAC' > >> case CRYPTO_AES_256_GMAC: > >> ^ > >> 3 errors generated. > >> --- xform_esp.o --- > >> > > > > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. Why? > > What do you mean? > > There was some temporary confusion regarding the LINT conf being dynamically generated (and thus properly ignored by svn), now resolved. -Patrick