From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Mar 11 12:55:13 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DC7CB16A4CE; Thu, 11 Mar 2004 12:55:13 -0800 (PST)
Received: from ahze.ahze.net (adsl-068-209-163-003.sip.clt.bellsouth.net
	[68.209.163.3])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9F87443D39; Thu, 11 Mar 2004 12:55:13 -0800 (PST)
	(envelope-from ahze@ahze.net)
Received: from [192.168.1.5] (eamc.ahze.net [192.168.1.5])
	by ahze.ahze.net (Postfix) with ESMTP
	id 024103D4; Thu, 11 Mar 2004 15:57:08 -0500 (EST)
In-Reply-To: <20040311090448.GY33033@voodoo.oberon.net>
References: <200403090157.i291vIGZ030464@www.freebsd.org>
	<20040310162326.GR33033@voodoo.oberon.net>
	<20040311080459.GA48315@alumni.csie.nctu.edu.tw>
	<20040311090448.GY33033@voodoo.oberon.net>
Mime-Version: 1.0 (Apple Message framework v613)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <5D75AD1A-739E-11D8-9C2D-000A958C81C6@ahze.net>
Content-Transfer-Encoding: 7bit
From: Michael Johnson <ahze@ahze.net>
Date: Thu, 11 Mar 2004 15:55:01 -0500
To: Kirill Ponomarew <krion@FreeBSD.org>
X-Mailer: Apple Mail (2.613)
cc: freebsd-ports-bugs@FreeBSD.org
cc: Ying-Chieh Chen <yinjieh@csie.nctu.edu.tw>
Subject: Re: ports/63955: [Patch] x11-toolkits/p5-Tk -- update 804.025.b6 ->
	804.025.b16 and make portlint happy
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2004 20:55:14 -0000


On Mar 11, 2004, at 4:04 AM, Kirill Ponomarew wrote:

> Hi,
>
> On Thu, Mar 11, 2004 at 04:04:59PM +0800, Ying-Chieh Chen wrote:
>> I approve the changes.
>>
>> Thanks for your help.
>>
>> On Wed, Mar 10, 2004 at 05:23:26PM +0100, Kirill Ponomarew wrote:
>>> Hi,
>>>
>>> On Mon, Mar 08, 2004 at 05:57:18PM -0800, michael johnson wrote:
>>>
>>> Could you please review it and approve/reject the changes?
>>>
>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/63955
>
> Thank you, could you please investigate what is going wrong
> with "make test" ?
>
> Failed 43/46 test scripts, 6.52% okay. 2082/2504 subtests failed, 
> 16.85% okay.
> *** Error code 2
>
> -Kirill
>

after looking at make test I looked at what the errors were and they 
are in

#     Expected: '26x15'
#  t/listbox.t line 1003 is: ok(getsize($mw), "26x15"); # TODO
t/listbox....................ok 276/437# Test 276 got: '30x20' 
(t/listbox.t at line 1006 *TODO*)
#     Expected: '26x15'
#  t/listbox.t line 1006 is: ok(getsize($mw), "26x15"); # TODO
t/listbox....................NOK 437# Test 437 got: 'x 0 1' 
(t/listbox.t at line 2004)
#     Expected: 'x 0 0.5'

and after looking at t/listbox it says # TODO so that mean's it's not 
finished. but I am getting 99.92% ok

Failed 1/46 test scripts, 97.83% okay. 2/2618 subtests failed, 99.92% 
okay.
*** Error code 2

michael