From owner-freebsd-hackers@FreeBSD.ORG Fri Mar 28 13:35:34 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4DEFEE96 for ; Fri, 28 Mar 2014 13:35:34 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E19A2D42 for ; Fri, 28 Mar 2014 13:35:33 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.8/8.14.8) with ESMTP id s2SDZT3v073582; Fri, 28 Mar 2014 15:35:29 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s2SDZT3v073582 Received: (from kostik@localhost) by tom.home (8.14.8/8.14.8/Submit) id s2SDZT6k073581; Fri, 28 Mar 2014 15:35:29 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 28 Mar 2014 15:35:29 +0200 From: Konstantin Belousov To: Ryan Stone Subject: Re: [PATCH] Support PCIe Alternative RID Interpretation (ARI) Message-ID: <20140328133529.GV21331@kib.kiev.ua> References: <20140316141216.GA21331@kib.kiev.ua> <20140319140236.GM21331@kib.kiev.ua> <20140325211355.GG21331@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V8Y3+xXnhQGsvjWT" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: "freebsd-hackers@freebsd.org" , Neel Natu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2014 13:35:34 -0000 --V8Y3+xXnhQGsvjWT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 27, 2014 at 02:48:36PM -0400, Ryan Stone wrote: > On Tue, Mar 25, 2014 at 5:13 PM, Konstantin Belousov > wrote: > > Well, either the interface I described is provided by pci core, or > > iommu has to de-facto implement it itself. IMO it is clearer to have > > it in pci, but I do not want to block your work on this. >=20 > Yes, but this amounts to some simple masking and shifting on the RID. > I don't think that's a very high burden. Well, as I learned during iommu development, a typo there could lay unnoticed for long time and than beat. This is due to most modern systems being PCIe and slot/function often equal to zero, or at least function equal to zero. >=20 > > I mean, that slot and func should be obtained using pci accessors where > > needed. It is definitely not perf-critical, and I dislike having both > > bsf and rid in the context structure more, then using accessors. >=20 > Ok, I've updated the DMAR patch to use pci accessors instead. This > required moving the initialization of ctx_tag.owner earlier in the > initialization of the DMAR ctx, but beyond that the change was > trivial. What is the URL ? --V8Y3+xXnhQGsvjWT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTNXqgAAoJEJDCuSvBvK1BWnkP/2HeUh/ShjHd73WazR3M99qu n4dblfySmM2LSMXfoQxrO1H5/lUQQneAmAEw5Bt3qEVEHPSvItyEPxThnqf8DmCe JzbXm9+lLLK8ZfdGCMVXGOEmo5+fZb34TtV2JJo+x9rNRYeWHtwGiX8FMBfIi4Yo l//DzAMgs8jqgiCHxYZ0pcCsFTogGFpTWU7WyHYkEWbOTTvm3mz2dGINMH6rkCuE zzHMOAClXllW5vhZCxlQ9xh7axeATIrpFMB6n3L08RDoKGxB3eGZI3A9xXUEijOy 8gf87hwhsZy8MnaKMU9dQzB7Ii9T0gKTdeV+Ez9IYTce0RoOUEZB2LnZX+NR/SuX U6orKLJLuVgnfWhrKNbyAoCpeDChdL78Jn0qJ96vCMd6HiJliHy3iZacYXkksJkY DGqpjnJDFC+7IerR+Lv4y8JLYPCjOm5+c8tFngL5zWzQujveajXQfHN16FsPQ8jU JdAGsVSVdMdnxTcUoCxgVYz51ecyoPuzor83kz4+DQbPauGh7EYRbxyxAkPVe0B7 BA5hHqFZSLKIGCyQZI3ESoR8muXtm2UbiU37kFeaTLd0njepFEF/rYtkDgdBz2op nPQYdjkYWfs4mJCQcrq8k7bNmqBFKdAk/jo9Oi4dHTttdYooo4j22zGDb0+6FIAZ dJ33sK40EJbI15FVla3Z =1E/x -----END PGP SIGNATURE----- --V8Y3+xXnhQGsvjWT--