Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Sep 2021 08:21:55 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: f73bc57ac903 - main - www/webkit2-gtk3: unbreak GSTREAMER=off after 895bc805a
Message-ID:  <YVLQo44j4fhlM9Hs@FreeBSD.org>
In-Reply-To: <202109280718.18S7IYNc062905@gitrepo.freebsd.org>
References:  <202109280718.18S7IYNc062905@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 28, 2021 at 07:18:34AM +0000, Baptiste Daroussin wrote:
> commit f73bc57ac903f6c6b69c2b9bf59d0b5598b56ead
> 
>     www/webkit2-gtk3: unbreak GSTREAMER=off after 895bc805a
>     
> ...
> +index 24c515c..043f534 100644
> +--- Source/WebCore/Sources.txt
> ++++ Source/WebCore/Sources.txt
> +@@ -364,7 +364,6 @@ Modules/webxr/XRInputSourceEvent.cpp @no-unify
> + Modules/webxr/XRInputSourcesChangeEvent.cpp @no-unify
> + Modules/webxr/XRReferenceSpaceEvent.cpp @no-unify
> + Modules/webxr/XRSessionEvent.cpp @no-unify
> +-accessibility/AXImage.cpp

Removing the file from Sources.txt should be enough, no?

> +diff --git Source/WebCore/accessibility/AXImage.cpp Source/WebCore/accessibility/AXImage.cpp
> +deleted file mode 100644
> +index d7226f2..0000000
> +--- Source/WebCore/accessibility/AXImage.cpp
> ++++ /dev/null
> +@@ -1,86 +0,0 @@
> +-/*
> +- * Copyright (C) 2021 Apple Inc. All rights reserved.
> +- *
> +- * Redistribution and use in source and binary forms, with or without
> +- * modification, are permitted provided that the following conditions
> +- * are met:

[ lots of lines skipped ]

What's the point of nullifying these two files as part of the patch?
This makes the patch quite unreadable...

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVLQo44j4fhlM9Hs>