From owner-cvs-all Sun Jun 4 19:39:20 2000 Delivered-To: cvs-all@freebsd.org Received: from mass.cdrom.com (adsl-63-206-88-224.dsl.snfc21.pacbell.net [63.206.88.224]) by hub.freebsd.org (Postfix) with ESMTP id BA80C37BD44; Sun, 4 Jun 2000 19:39:03 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Received: from mass.cdrom.com (localhost [127.0.0.1]) by mass.cdrom.com (8.9.3/8.9.3) with ESMTP id TAA14945; Sun, 4 Jun 2000 19:41:58 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Message-Id: <200006050241.TAA14945@mass.cdrom.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Josef Karthauser Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls extern.h ls.1 ls.c ls.h print.c In-reply-to: Your message of "Mon, 05 Jun 2000 03:33:38 BST." <20000605033336.Q620@pavilion.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 04 Jun 2000 19:41:58 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Sun, Jun 04, 2000 at 11:00:28PM +0100, Josef Karthauser wrote: > > > escape sequences into the code. That's just vile and Josef Karthauser > > > really needs to back this out or I can guarantee that somebody is > > > going to do it for him and that's not a good way of doing business; a > > > man should always shoot his own dog. > > The dog's been put out of its misery. Joe - when you go to make a commit, there's this field in the message towards the bottom that says "Reviewed by:". In situations like this, ie. when you're touching something that people are really sensitive about, it's a Very Good Idea to have someone fairly authoritative on the topic sign off on your changes so you can put their name there. I'll note that Andrey has at least three valid followups on your changes that should have been dealt with before you committed them. In this case, less haste would have meant more speed. -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message