Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Oct 2012 00:42:33 +0200 (CEST)
From:      Martin Tournoij <martin@arp242.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        ehaupt@FreeBSD.org
Subject:   ports/172915: [PATCH] x11/xterm -- Restore 256color option
Message-ID:  <20121020224233.A313317018@mx1.arp242.net>
Resent-Message-ID: <201210202250.q9KMo1ko036368@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         172915
>Category:       ports
>Synopsis:       [PATCH] x11/xterm -- Restore 256color option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 20 22:50:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Martin Tournoij
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD cthulhu.daemonforums.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Apr 14 22:52:12 CEST 2011 carpetsmoker@cthulhu.daemonforums.org:/usr/obj/usr/src/sys/CTHULHU i386


	
>Description:
The option to enable/disable 256 colors support was removed about a month ago.
This patch re-adds the option, enabeling it by default.

The commit message says:
``build 256 color support by default and remove it as an option; this change
comes with no price, no additional dependencies''

Well, that's not quite true. All the colors in Vim are now different for the
default colorscheme.
After looking at the same colors for a decade, this was quite the shock!

Perhaps Vim can be re-configured, I'm not sure. But I'd rather just use 16
colors (more colors is not better).

Thanks :)
Martin

>How-To-Repeat:
	
>Fix:
--- Makefile.orig       2012-10-21 00:39:06.000000000 +0200
+++ Makefile    2012-10-21 00:39:38.000000000 +0200
@@ -2,6 +2,7 @@
 
 PORTNAME=      xterm
 PORTVERSION=   284
+PORTREVISION=  1
 CATEGORIES=    x11
 MASTER_SITES=  ftp://invisible-island.net/xterm/ \
                CRITICAL
@@ -17,18 +18,19 @@
 GNU_CONFIGURE= yes
 
 CONFIGURE_ENV+=        LIBS="-L${LOCALBASE}/lib"
-CONFIGURE_ARGS+=       --with-utempter --enable-narrowproto --enable-256-color
+CONFIGURE_ARGS+=       --with-utempter --enable-narrowproto
 
 CPPFLAGS+=     -I${LOCALBASE}/include
 
-OPTIONS_DEFINE=        WCHAR LUIT DECTERM PCRE GNOME DABBREV
+OPTIONS_DEFINE=        WCHAR LUIT DECTERM PCRE GNOME DABBREV 256COLOR
 
 DABBREV_DESC=  Enable support for dabbrev-expand
 DECTERM_DESC=  Enable DECterm Locator support
 LUIT_DESC=     Use LUIT for locale convertion from/to UTF-8
 WCHAR_DESC=    Enable wide-character support
+256COLOR_DESC= Enable 256-color support
 
-OPTIONS_DEFAULT=WCHAR LUIT
+OPTIONS_DEFAULT=WCHAR LUIT 256COLOR
 
 .include <bsd.port.options.mk>
 
@@ -54,6 +56,10 @@
 CONFIGURE_ARGS+=       --enable-dabbrev
 .endif
 
+.if ${PORT_OPTIONS:M256COLOR}
+CONFIGURE_ARGS+=       --enable-256-color
+.endif
+
 .if ${PORT_OPTIONS:MGNOME}
 USE_GNOME=     desktopfileutils
 PLIST_SUB+=    GNOME=""
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121020224233.A313317018>