From owner-svn-src-projects@freebsd.org Sat Feb 29 04:57:56 2020 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE3792558E7 for ; Sat, 29 Feb 2020 04:57:56 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660081.outbound.protection.outlook.com [40.107.66.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TvKv0qJhz4V6C; Sat, 29 Feb 2020 04:57:54 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4g2AOhFjfSqCL0th6PWeX9vrVrf6jXK59LKplNamqnLKVfDKPWHRSed1I8Z3DTiz9dmZ4fPko7xOp9iMdOMOluXTOWt1zY3x1NH3SuPgo9EQfRErc9nUOswJc9kS+uQQ+yG0Lf4wnzMlzYZ2ehIJTzCy7u6PoSIhzgrZlfEaAyEsAPgQE95S42yTargDY61pPdBlgqOx8B3gAvHS2ZrgCUldOU4noMatp+1DKxrvgFdQKQtm03xL7GectqeS/Kg+Vy9jvc5enjmkA/Zoik7qcj/YbrNV0NvHe2apQrIgLc1zBhxdbGTMesaKIj+6wQRPhxHyhdxSNPRMMHYj/wkwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=epKqRfB/MUJyywcc06DIe0PNPubBj+R6ULv9frOSaBw=; b=fkKzlx21304mAbhET2HzUMixeQahxBtc8yMn07o6OGmUx42stnoutpP/V74rKms4xsOz0ILK1uZ17/MBMDsL5j1QcsI3DTvA3LvmL9uGi17528nL9AHp4iONQcf7yUsPzq9/7x13mxuxOXJQaJ46xzQ2K8UXhcmNMCiGz4f1nwB5y6IdWlisSYuigVvMbjlZ+VrmYhigigELnhyhdQ6ofo/+9MS2i1E/TECuzXsku6fMTBpC+5rHMqHvmW8Jwl0fNMYinG09Ip4G8oGF4v0ftIDwev3Er+Oid+ufJYSIDukQDhUqF8Y8UWoD7QABJgz3McMd1O8d/6/0H92RO52RaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM (10.255.46.82) by YTBPR01MB3135.CANPRD01.PROD.OUTLOOK.COM (10.255.13.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Sat, 29 Feb 2020 04:57:52 +0000 Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::a50d:6237:4074:f9c4]) by YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::a50d:6237:4074:f9c4%6]) with mapi id 15.20.2772.018; Sat, 29 Feb 2020 04:57:42 +0000 From: Rick Macklem To: John Baldwin , Rick Macklem , "src-committers@freebsd.org" , "svn-src-projects@freebsd.org" Subject: Re: svn commit: r358053 - projects/nfs-over-tls/sys/fs/nfsclient Thread-Topic: svn commit: r358053 - projects/nfs-over-tls/sys/fs/nfsclient Thread-Index: AQHV7dDxwBYPOhnzy0GhC4ymRJHhbqgxm+ku Date: Sat, 29 Feb 2020 04:57:42 +0000 Message-ID: References: <202002172110.01HLAXZY003012@repo.freebsd.org>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40476f8c-550a-4f54-65e1-08d7bcd3e900 x-ms-traffictypediagnostic: YTBPR01MB3135: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03283976A6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(396003)(39860400002)(199004)(189003)(55016002)(81166006)(33656002)(2906002)(9686003)(8676002)(8936002)(81156014)(71200400001)(450100002)(7696005)(66476007)(6506007)(64756008)(478600001)(5660300002)(786003)(966005)(316002)(52536014)(66556008)(86362001)(186003)(66946007)(66446008)(76116006)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB3135; H:YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +eMSQBoY9T3K7JcXEXQd8jwwCtQzNA5hMpoQBFD2EcwVNzSXDCH9burTiDIG21UhWlNAhBnO+HshvrsbxwL0cOooMeUxqgWiPLyH34hxrdWMaTGPt906hh/Ke+12TvvyZn50feelqMYInFRUvdhRQrpWpsCO6Ohd5Vi5qQTIZuu5SucgLVRxCwZmZpAt4TlpWFQLn1m3i6gPTYLvxM24CmMa6OLun/jCJJRfKDp7x71DMgzs/NMxZXtM1cn+t5U3n22aaWJSlE9K/Bmcst9an4vMvNRuEsldKm8D+gJtB1KWRiwZkHEucDzoWcS84HejThgd4gcs2iwzQjjDSgO0V+poftieS8wO8e8RqerE9vfp6e9ezI+hzmuLOEhjiLMRVq6NOKQfAXIbKcbsn1EdFW+XAJ7gbAXc3lW016tyYdtQsLsPoNl8BMyJ6Autgvdmk+Ko53wNxucyReIIl6+Sbu2WJXfxDguBtpfvlJvAvkr3BKii+AKiEeiMe0d0Yv6gqOZdxMcMcn2/6JCSjJN2aQ== x-ms-exchange-antispam-messagedata: qUZ0Vxnv56dszgzIKktaFbbE0cRZXauOjefiqAsCeFo/8gytYA9RLoUCeWDNKn9GWlktZZ31SEEph6ako7J87p9ZxOjjsaAWrCZHbDxv6nh0MEnDZVbY0oUfH1nYx+dFfSMYehihXLznkhOhID176eumWh2GRsR1gI5hfRVtDWTqYQMPBH49O9GrFTtSZc8IIiy4rofddUjO60PCH4oQ0g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 40476f8c-550a-4f54-65e1-08d7bcd3e900 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2020 04:57:42.8763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kcf78DKZ/R6KVY4ZCrMNjx1FWxgOc2k71XTwWUcVKNZ1UZKH94P8ED1aj3Gz+v7ijxde7PzYgQyPBsPqTUivKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB3135 X-Rspamd-Queue-Id: 48TvKv0qJhz4V6C X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.81 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.70 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.40)[ipnet: 40.64.0.0/10(-3.83), asn: 8075(-3.10), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[81.66.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Feb 2020 04:57:56 -0000 John Baldwin wrote:=0A= >On 2/17/20 1:10 PM, Rick Macklem wrote:=0A= >> Author: rmacklem=0A= >> Date: Mon Feb 17 21:10:32 2020=0A= >> New Revision: 358053=0A= >> URL: https://svnweb.freebsd.org/changeset/base/358053=0A= >>=0A= >> Log:=0A= >> Update nfs_clrpcops.c to handle ext_pgs mbufs, including the additiona= l=0A= >> argument to nfscl_reqstart() to tell it if it should build ext_pgs mbu= fs.=0A= >>=0A= >> This completes most of the conversion to support of ext_pgs mbufs, but= =0A= >> there are still a couple of areas to fix.=0A= >> 1 - The code that the MDS uses to do a proxy to a DS for a pNFS server= .=0A= >> 2 - The krpc code on the receive side. (The NFS code now handles the= =0A= >> ext_pgs mbufs, but they are being created by copying the regular m= buf=0A= >> list when the NFS code gets it from the krpc.) The krpc still need= s=0A= >> to be fixed so it can handle a list of ext_pgs mbufs handed to it= =0A= >> by soreceive().=0A= >=0A= >Note that the current KTLS RX support I've worked on is a bit different in= that=0A= >it doesn't use ext_pgs mbufs. Instead the socket buffer contains a list o= f=0A= >records (OpenSSL uses recvmsg()) where there is a control mbuf with the TL= S=0A= >header followed by a chain of normal mbufs with the data. As such, you wi= ll=0A= >only have to construct ext_pgs mbufs for the send side. Receive will stil= l=0A= >be getting regular mbufs. For receive you probably want to check the TLS= =0A= >record type and do something (not sure?) with any non-application-data rec= ords,=0A= >but otherwise just treat the payload of application-data records the same = as=0A= >you do for the non-TLS case.=0A= Ok. I've already done the receive side code changes to handle ext_pgs mbufs= =0A= in the krpc/nfs code, so if it becomes easier/more efficient to put the rec= eive=0A= data in ext_pgs mbufs, that can be handled. (Someday there may be net=0A= interfaces that perform better using ext_pgs mbufs?)=0A= =0A= Any non-data records that need to be handled by OpenSSL in userspace can=0A= be passed up/handled by the daemons, similar to SSL_connect()/SSL_accept().= =0A= =0A= Thanks for the info John, rick=0A= =0A= --=0A= John Baldwin=0A=