From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 1 20:29:09 2009 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B211D106568F; Sun, 1 Nov 2009 20:29:09 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [192.147.25.65]) by mx1.freebsd.org (Postfix) with ESMTP id 80BDE8FC18; Sun, 1 Nov 2009 20:29:09 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lerami; d=lerctr.org; h=Received:Received:Message-ID:In-Reply-To:References:Date:Subject:From:To:Cc:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding:X-Priority:Importance:X-Spam-Score:X-LERCTR-Spam-Score:X-Spam-Report:X-LERCTR-Spam-Report:DomainKey-Status; b=d43Kl6IHo3mcqaFK4Zf0jF+vip693OCcYhIH1mi2bcZSmdoHnh0PoDn5ZPAAts9jRT1eeBwl4scPZ8a22aX9cyRaEUZNo6BIaD3faZcCYYOLRKnHZZjGzBs8rTyfgadvQ0rAAXhhpBEE98873C+4GgX1mebSqJSm3bdrli6vxNA=; Received: from localhost.lerctr.org ([127.0.0.1]:54470 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtp (Exim 4.69 (FreeBSD)) (envelope-from ) id 1N4h2u-0009Bp-FD; Sun, 01 Nov 2009 14:29:05 -0600 Received: from 76.205.169.61 (SquirrelMail authenticated user ler) by webmail.lerctr.org with HTTP; Sun, 1 Nov 2009 14:29:04 -0600 Message-ID: In-Reply-To: <20091101194826.GA69806@owl.midgard.homeip.net> References: <20091101194826.GA69806@owl.midgard.homeip.net> Date: Sun, 1 Nov 2009 14:29:04 -0600 From: "Larry Rosenman" To: "Erik Trulsson" User-Agent: SquirrelMail/1.4.20-RC2 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -4.3 (----) X-LERCTR-Spam-Score: -4.3 (----) X-Spam-Report: SpamScore (-4.3/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, TW_JH=0.077 X-LERCTR-Spam-Report: SpamScore (-4.3/5.0) ALL_TRUSTED=-1.8, BAYES_00=-2.599, TW_JH=0.077 DomainKey-Status: no signature Cc: freebsd-ports-bugs , James Chang , freebsd-ports@freebsd.org Subject: Re: lsof build failed under FreeBSD 7.2-STABLE AMD64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2009 20:29:09 -0000 I'm in contact with Vic Abell (LSOF author), and will get an update out soon. Thanks! On Sun, November 1, 2009 1:48 pm, Erik Trulsson wrote: > [lsof maintainer added to Cc:] > > On Sun, Nov 01, 2009 at 12:10:07PM -0600, Larry Rosenman wrote: >> Are your system sources current? and do they match the running system? >> >> it compiles file for me on: > > But if you update your FreeBSD system to the very latest (or at least > after > Oct 29) it will not compile fine for you either. > > The following commit to 7-stable broke lsof compilation: > > Author: jhb > Date: Thu Oct 29 15:10:38 2009 > New Revision: 198595 > URL: http://svn.freebsd.org/changeset/base/198595 > > Log: > MFC 196615: > Extend the device pager to support different memory attributes on > different > pages in an object. > - Add a new variant of d_mmap() currently called d_mmap2() which > accepts > an additional in/out parameter that is the memory attribute to use > for > the requested page. > - A driver either uses d_mmap() or d_mmap2() for all requests but not > - both. > The current implementation uses a flag in the cdevsw (D_MMAP2) to > indicate > that the driver provides a d_mmap2() handler instead of d_mmap(). > This > is done to make the change ABI compatible with existing drivers and > MFC'able to 7 and 8. > > The lsof source code contains code to handle the problem for -CURRENT. The > following part from dialects/freebsd/dlsof.h is the relevant part which > describes the problem and contains a solution for 9-CURRENT. > > # if FREEBSDV>=9000 > /* > * The FreeBSD 9 and above d_mmap2_t function typedef in > needs > * the definition of vm_memattr_t for a pointer, but that definition is > only > * available under _KERNEL in . Defining _KERNEL before > * including causes many compilation problems, so this > * expedient (hack) is used. > */ > #define vm_memattr_t void > # endif /* FREEBSDV>=9000 */ > > #include > > # if FREEBSDV>=9000 > #undef vm_memattr_t > # endif /* FREEBSDV>=9000 */ > > > The 'if FREEBSDV>=9000' parts need to be mofified to make it work for > older > releases too now that the d_mmap2_t function has been MFC'd. > > > > > > > -- > > Erik Trulsson > ertr1013@student.uu.se > -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 512-248-2683 E-Mail: ler@lerctr.org US Mail: 430 Valona Loop, Round Rock, TX 78681-3893